/locate command

[balt-dev]

Adds a /locate command to find where a player is without having to scroll through tab.

Note that this may add additional complexity to PR #101.

[balt-dev]

Note that there's no formatting for now, since the command is fully resolved on the server! In order to change this, I'd probably need to factor out part of CelesteNet.Client.Components.CelesteNetPlayerListComponent.

[balt-dev]

I'd make this a draft PR but I can't find the button :P

[balt-dev]

Much better!

[balt-dev]

Here's how it handles the randomizer:

[RedFlames]

Suggestion of a rewrite of your HandleLocate, although it's not perfect either 🤔
(And untested, I haven't actually tried to compile this)

        public void HandleLocate(DataChat chat) {
            // For some reason, using the actual target field always came up as null for me.
            // Instead, I'm opting to use the Player field, Because It Works :TM:
            var target = chat.Player;

            chat.Player = null;
            chat.Tag = "";

            if (player == null) {
                chat.Text = $"Target of /locate not found.";
                return;
            }
            DataPlayerState? state;
            if (Client?.Data?.TryGetBoundRef(target, out state) == false || state == null) {
                chat.Text = $"{target.FullName} isn't in game or is in another channel.";
                return;
            }

            // Abuse the player list representation to get a formatted version
            var fakeBlob = new BlobPlayer();
            Context.Get<CelesteNetPlayerListComponent>().GetState(fakeBlob, state);
            var location = fakeBlob.Location;
            string iconEmoji = "";

            if (location.Icon != null) {
                string emojiId = $"celestenet_SID_{location.SID}_";
                if (!Emoji.Registered.Contains(emojiId)) {
                    // We need to downscale the icon to fit in chat
                    MTexture? icon = 
                        (fakeBlob.LocationMode & LocationModes.Icons) != 0 && GFX.Gui.Has(location.Icon) 
                            ? GFX.Gui[location.Icon]
                            : null;
                    if (icon != null) {
                        float scale = 64f / icon.Height;

                        var tex = new MTexture(new MTexture(icon.Texture), icon.ClipRect) { ScaleFix = scale };
                        Emoji.Register(emojiId, tex);
                        Emoji.Fill(CelesteNetClientFont.Font);
                    }
                }
                if (Emoji.Registered.Contains(emojiId))
                    iconEmoji = $":{emojiId}:";
            }
            
            string locationName = location.Name;
            
            if (!string.IsNullOrEmpty(iconEmoji))
                locationName = $"{iconEmoji} {locationName}";
            
            if (!string.IsNullOrEmpty(location.Side))
                locationName += $" {location.Side}";
            
            chat.Text = $"{target.FullName} is in room '{location.Level}' of {locationName}.";
        }

In any case you need to take out the throw statement, I'm assuming that's come over from Server ChatModule's error handling stuff? :v
I also don't have your empty SID check taken into account here, hadn't seen that yet.

[balt-dev]

Pushed the refactor, thanks

[balt-dev]

@RedFlames review?

[balt-dev]

I've fixed everything except the handshake thing, which I saw on Discord might take a bit of time.

[balt-dev]

Here's an image of the latest commit in action!

[balt-dev]

The unsupported client doesn't get /locate in the command list either.

[RedFlames]

I'm also fairly certain the CmdLocate doesn't need its ValidatePlayerSession because mostly that stuff should already be handled by the ParamPlayerSession when it gets parsed, but eh, also doesn't hurt or anything.

Anyways I think I'll merge this? And prepare to release a new client build with the recent stuff... #152 and all that. v2.4.0 milestone
(I think your other PR, the Pico8 Ghosts will still have to wait for later 🙂)

[RedFlames]

Fixed those enum Options related issues, and a few more small things that I noticed.

Hopefully there isn't anything else we/I overlooked because I'm quite ready to merge this.