Skip to content

Commit

Permalink
Add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
flobernd committed Nov 4, 2024
1 parent 21614ce commit 9ff14fa
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/Decoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -3533,6 +3533,8 @@ static void ZydisSetEffectiveOperandWidth(ZydisDecoderContext* context,
(instruction->opcode_map == ZYDIS_OPCODE_MAP_MAP4) &&
(instruction->raw.evex.pp == 0x01))
{
// TODO: Add generator flag

// EVEX encoded instructions in MAP4 must use 0x66 as the mandatory prefix AND the
// operand-size override
index = 1;
Expand Down Expand Up @@ -4398,7 +4400,7 @@ static ZyanStatus ZydisNodeHandlerEvexSCC(ZydisDecoderContext* context,
// as the DFV specifier. Other than the regular `.vvvv` NDS/NDD specifier, the DFV
// specifier bits are not inverted.

// All APX conditional CMP and TEST instructions must have a SCC filter!
// All APX conditional CMP and TEST instructions must have an SCC filter!

context->vector_unified.vvvv = (~context->vector_unified.vvvv) & 0x0F;
context->vector_unified.V4 = 0;
Expand Down

0 comments on commit 9ff14fa

Please sign in to comment.