Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v1.5.1 #77

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Jan 9, 2025

@mochaaP mochaaP force-pushed the mochaa/bump-version branch 8 times, most recently from eee7291 to ddc65a8 Compare January 9, 2025 11:41
@athre0z
Copy link
Member

athre0z commented Jan 9, 2025

Feel free to just pin the runs-on directive to an older version of Ubuntu. We should probably pin OS versions in general to avoid this kind of random breakage in the future. The i386 build can then be fixed separately.

@mochaaP mochaaP force-pushed the mochaa/bump-version branch 3 times, most recently from 552e1e1 to 1d2f489 Compare January 9, 2025 12:46
@mochaaP mochaaP force-pushed the mochaa/bump-version branch from 1d2f489 to 66398b2 Compare January 9, 2025 13:00
@mochaaP
Copy link
Contributor Author

mochaaP commented Jan 9, 2025

okay it was fixed 😇

Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@flobernd
Copy link
Member

flobernd commented Jan 9, 2025

LGTM from my side as well! Thanks.

@flobernd flobernd merged commit 53f6d27 into zyantific:master Jan 9, 2025
48 checks passed
@flobernd
Copy link
Member

flobernd commented Jan 9, 2025

I created a new release + tag.

@mochaaP
Copy link
Contributor Author

mochaaP commented Jan 10, 2025

https://github.com/mesonbuild/wrapdb/pull/1862/checks

for the alpine (x86) one should be a one line fix:

diff --git a/tests/ArgParse.cpp b/tests/ArgParse.cpp
index 612a5dd..8f83333 100644
--- a/tests/ArgParse.cpp
+++ b/tests/ArgParse.cpp
@@ -57,7 +57,7 @@ auto cvt_string_view(const ZyanStringView *sv)
 /* Unnamed args                                                                                   */
 /* ---------------------------------------------------------------------------------------------- */
 
-static auto UnnamedArgTest(ZyanU64 min, ZyanU64 max)
+static auto UnnamedArgTest(ZyanUSize min, ZyanUSize max)
 {
     const char* argv[]
     {

I have zero idea about why linking doesn't work with clang-cl + lld-link (dynamic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants