-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for null option definition #2003
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2003 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 636 636
Lines 18720 18720
Branches 3901 3901
=======================================
Hits 17042 17042
Misses 1677 1677
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Thanks for fixing all the definitons
"succesfully" 😋
Before
[2024/01/03 20:37:05.829] [FATAL] [main.js:48] Error initializing Zowe CLI:
ImperativeError: An option definition is null or undefined.
at CommandPreparer.performBasicOptionValidation (/root/gh/zowe/zowe-cli/packages/imperative/lib/cmd/src/CommandPreparer.js:290:23)
...
at Imperative.<anonymous> (/root/gh/zowe/zowe-cli/packages/imperative/lib/imperative/src/Imperative.js:238:53)
at Generator.next (<anonymous>) {
mDetails: {
msg: 'An option definition is null or undefined.',
additionalDetails: 'CURRENT_TREE:\n' +
'[{"name"... 1592384 more characters
*** THIS IS THE ENTIRE COMMAND TREE ***
},
mMessage: 'An option definition is null or undefined.'
}
After
[2024/01/03 20:37:05.829] [FATAL] [main.js:48] Error initializing Zowe CLI:
ImperativeError: An option definition is null or undefined.
at CommandPreparer.performBasicOptionValidation (/root/gh/zowe/zowe-cli/packages/imperative/lib/cmd/src/CommandPreparer.js:290:23)
...
at Imperative.<anonymous> (/root/gh/zowe/zowe-cli/packages/imperative/lib/imperative/src/Imperative.js:238:53)
at Generator.next (<anonymous>) {
mDetails: {
msg: 'An option definition is null or undefined.',
additionalDetails: 'COMMAND_DEFINITION:\n' +
`{"handler":"/root/gh/zowe/zowe-cli/packages/cli/lib/zosfiles/copy/ds/Ds.handler",
*** THIS GIVES YOU THE COMMAND HANDLER PATH***
},
mMessage: 'An option definition is null or undefined.'
}
Only 2 integration test snapshots missing. Update: Those integration test files are fixed 😋 |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks timothy!
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
Fixes #2002 and also a typo in help for the
zos-workflows create
commands (definiton
->definition
)