-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding test-specific tsconfig files in appropriate dirs #1996
Conversation
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1996 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 635 635
Lines 18610 18610
Branches 3859 3859
=======================================
Hits 16941 16941
Misses 1668 1668
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR: LGTM! 😋
I like this solution a lot.
It resolved the problem of having to import @types/jest
in a random file for those Jest functions (describe, afterAll, ...
) to be recognized as actual functions.
I'm curious if we could do some technique to reduce duplication. Something like...
"extends": "../../tsconfig.json",
One thing to keep in mind that this only fixes tests that are under the packages/PKG/__tests__/
directory. For example, this won't help with
packages/imperative/src/utilities/__tests__/CliUtils.unit.test.ts
since the tsconfig.json
is under packages/imperative/__tests__/
😋
Signed-off-by: Amber Torrise <at895452@broadcom.net>
I take that back. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ATorrise!
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Configures typescript test files to include jest type information, reducing the amount of distracting, not-real-yet-still-highlighted-as-such errors when working in test files
How to Test
Pull branch and start opening up some test files, making sure there are no errors like:
Review Checklist
I certify that I have: