-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetcher-core crate #37
Merged
nachog00
merged 32 commits into
zingolabs:fetcher-core_crate
from
nachog00:fetcher-core_crate
Feb 10, 2025
Merged
fetcher-core crate #37
nachog00
merged 32 commits into
zingolabs:fetcher-core_crate
from
nachog00:fetcher-core_crate
Feb 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nachog00
commented
Feb 7, 2025
- Initialised cargo-fetcehr crate
- initialised file structure
- new error.rs module
- new cache.rs module
- new binaries module
- new binaries module
- updated fetcher-core lib.rs
- format cargo.toml
- new get_path function in cache
- new error "InvalidResource"
- remove binary_cofig module not nieeded anymore after next refactor
- .
- removed unnecesary implementations of ResourceType
- implemented correct Resource trait
- implemented Resource for Binaries
- updated public api to use latest Resource implementation
- added tokio as a dep of fetcher-core
- more logging
- implemented get_name as Resource for Binaries
- fix: &Cache for get_path
- removed unnecesary 'get' fn and implemented dummy fn's for Binaries's Resource trait
- updated get_result 's types
- added assert!(false) in dummy function to see outpu on fail
not nieeded anymore after next refactor
Closed
6 tasks
This PR aims to implement the functionality outlined in #31 As of now, it provides a base structure for serving arbitrary resources. The old |
Merging this into feature branch New PR's can be open against this branch to elaborate on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.