Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetcher-core crate #37

Merged
merged 32 commits into from
Feb 10, 2025

Conversation

nachog00
Copy link
Contributor

@nachog00 nachog00 commented Feb 7, 2025

  • Initialised cargo-fetcehr crate
  • initialised file structure
  • new error.rs module
  • new cache.rs module
  • new binaries module
  • new binaries module
  • updated fetcher-core lib.rs
  • format cargo.toml
  • new get_path function in cache
  • new error "InvalidResource"
  • remove binary_cofig module not nieeded anymore after next refactor
  • .
  • removed unnecesary implementations of ResourceType
  • implemented correct Resource trait
  • implemented Resource for Binaries
  • updated public api to use latest Resource implementation
  • added tokio as a dep of fetcher-core
  • more logging
  • implemented get_name as Resource for Binaries
  • fix: &Cache for get_path
  • removed unnecesary 'get' fn and implemented dummy fn's for Binaries's Resource trait
  • updated get_result 's types
  • added assert!(false) in dummy function to see outpu on fail

@nachog00 nachog00 linked an issue Feb 7, 2025 that may be closed by this pull request
6 tasks
@nachog00 nachog00 requested review from ala-mode and zancas February 7, 2025 07:04
@nachog00 nachog00 marked this pull request as draft February 7, 2025 07:05
@nachog00
Copy link
Contributor Author

nachog00 commented Feb 7, 2025

This PR aims to implement the functionality outlined in #31

As of now, it provides a base structure for serving arbitrary resources.

The old fetcher logic can already be ported in.

@nachog00 nachog00 changed the base branch from dev to fetcher-core_crate February 10, 2025 23:10
@nachog00 nachog00 marked this pull request as ready for review February 10, 2025 23:10
@nachog00
Copy link
Contributor Author

Merging this into feature branch fetcher-core_crate.

New PR's can be open against this branch to elaborate on the fetcher-core feature until it is ready to land in dev.

@nachog00 nachog00 merged commit b64b222 into zingolabs:fetcher-core_crate Feb 10, 2025
This was referenced Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fetcher-core
2 participants