rephrase passage about current version and add its git SHA #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macovsky
commented
Nov 1, 2024
| @@ -111,8 +111,8 @@ Thanks to [[https://t.me/ritsch_master][=@ritsch_master=]] | |||
| ** Building TDLib | |||
|
|
|||
| [[https://core.telegram.org/tdlib][TDLib]] is the library for building Telegram clients. It requires a | |||
| large amount of memory to be built. Make sure you are using TDLib | |||
| version greater or equal to {{{eval(telega-tdlib-min-version, t)}}}. | |||
| large amount of memory to be built. Make sure you are using TDLib version | |||
There was a problem hiding this comment.
WDYT about setting the concrete version instead of "greater or equal to" since 1.8.38 is not supported yet?
also added SHA to help with installation
There was a problem hiding this comment.
Too many variables, simple string like "1.8.39-056963e" is better, also, it resembles what M-x telega-version RET returns
There was a problem hiding this comment.
how about a compromise: one extra var as simple string for manual but code stays intact?
macovsky
force-pushed
the
update-readme
branch
from
1038632 to
8c10c82
Compare
macovsky
changed the title
macovsky
changed the title
zevlg
reviewed
Nov 2, 2024
macovsky
force-pushed
the
update-readme
branch
from
8c10c82 to
10d1b6e
Compare
macovsky
force-pushed
the
update-readme
branch
from
10d1b6e to
a51e38b
Compare
zevlg
reviewed
Nov 3, 2024
| @@ -11,7 +11,8 @@ | |||
| ;; Version: 0.8.293 | |||
| (defconst telega-version "0.8.293") | |||
| (defconst telega-server-min-version "0.7.7") | |||
| (defconst telega-tdlib-min-version "1.8.29") | |||
| (defconst telega-tdlib-min-version-with-sha "1.8.29-12c1689b5") | |||
| (defconst telega-tdlib-min-version (car (split-string telega-tdlib-min-version-with-sha "-"))) | |||
There was a problem hiding this comment.
Wait, we have sha1 in the etc/Dockerfile, let's extract it from there while generating docs!
This avoids adding sha1 into multiple different places
There was a problem hiding this comment.
sounds good, closing this then.
zevlg
added a commit
that referenced
this pull request
Nov 9, 2024
- [upd] README.md update TDLib version - [enh] For documentation, extract TDLib version and branch from etc/Dockerfile, fixes #501 - [fix] Handle `avatar' palette context ignorance while reandering telega cat eyers, fixes - [enh] Use sender of message at point as default member for `telega-completing-read-chat-member', fixes #504 Version -> 0.8.391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.