Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL to point at prod relay #242

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Update URL to point at prod relay #242

merged 3 commits into from
Oct 10, 2024

Conversation

msub2
Copy link
Contributor

@msub2 msub2 commented Oct 9, 2024

Updates networking.js to point at the prod version of the relay. Opening as draft for now because I discovered that the automatic canvas screenshotting doesn't work as expected with WebGL-context canvases (the image it grabs with .toDataURL() is empty due to how WebGL rendering works) and I still need to find a good workaround for it. Once that's figured out everything else should be in place to bump the beacon version and make the switch.

@msub2 msub2 marked this pull request as ready for review October 10, 2024 02:33
@msub2
Copy link
Contributor Author

msub2 commented Oct 10, 2024

Alright, this updates the beacon to the latest version, which adds a fallback for A-Frame scenes specifically using the default screenshot component. This should be good enough for us to get started with image previews, I've left a TODO in the else branch to look into other potential workarounds for getting a canvas preview.

@msub2
Copy link
Contributor Author

msub2 commented Oct 10, 2024

Version bump to include zestyxyz/beacon@e321a58

@msub2 msub2 merged commit ec13af2 into main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants