Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(page-load-saga): apply mobile restriction logic to page load saga #2025

Merged
merged 2 commits into from
Jun 19, 2024
Merged

feat(page-load-saga): apply mobile restriction logic to page load saga #2025

merged 2 commits into from
Jun 19, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Jun 19, 2024

What does this do?

  • applies mobile restriction logic to page load saga
  • adds restricted route

Why are we making this change?

  • handling this logic in the page load saga prevents unexpected issues when rendering routes i.e. flickering when page load completes

How do I test this?

  • run tests as usual.
  • once merged this can be tested on development via mobile device.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 merged commit c28c5e1 into main Jun 19, 2024
5 checks passed
@domw30 domw30 deleted the feat/apply-mobile-restriction-to-page-load-saga branch June 19, 2024 11:08
@domw30 domw30 requested a review from a team June 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30