Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: espressif: fix chip revision reading #86590

Merged

Conversation

sylvioalves
Copy link
Collaborator

@sylvioalves sylvioalves commented Mar 3, 2025

Make sure chip revision reading returns real value for some especific chip revision, which is currently failing.

Prior PR #86202 fixed optimization issue and this fixes chip revision reading.

Fixes #86589

@sylvioalves sylvioalves force-pushed the bugfix/chip_rev_reading branch from 40ba448 to 755e6d4 Compare March 3, 2025 21:00
Make sure chip revision reading returns real value
for some especific chip revision, which is currently
failing.

Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
@sylvioalves sylvioalves force-pushed the bugfix/chip_rev_reading branch from 755e6d4 to 5570b93 Compare March 3, 2025 21:01
@sylvioalves sylvioalves marked this pull request as ready for review March 3, 2025 21:05
@sylvioalves sylvioalves added this to the v4.1.0 milestone Mar 3, 2025
@zephyrbot zephyrbot added the platform: ESP32 Espressif ESP32 label Mar 3, 2025
Copy link

@marekmatej marekmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kartben kartben requested a review from fabiobaltieri March 4, 2025 17:14
@kartben
Copy link
Collaborator

kartben commented Mar 4, 2025

fixes a medium & serious enough bug so should probably make it into 4.1. cc @fabiobaltieri

@fabiobaltieri fabiobaltieri added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Mar 4, 2025
@fabiobaltieri
Copy link
Member

Sounds good, marking as trivial so it gets merged earlier, I think we are better off merging it now and least have it out for a couple days before tagging 4.1.

@fabiobaltieri fabiobaltieri merged commit b8c710d into zephyrproject-rtos:main Mar 4, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: ESP32 Espressif ESP32 Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 won't read correct soc revision
6 participants