dts: arm: atmel: sam3x: add gpio header #86282
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gpio header is missing, which will lead to failures when declaring GPIO down the line in board overlays. Signed-off-by: Eve Redero <eve.redero@gmail.com>
zephyrbot
added
size: XS
zephyrbot
requested review from
attie-argentum,
mnkp,
nandojve,
pdgendt and
stephanosio
|
Hi @everedero , We are on release candidate phase at moment. |
pdgendt
previously approved these changes
Feb 25, 2025
The overlays can include the file, no? |
|
@pdgendt The other sam*.dtsi soc family files include it, like dts/arm/atmel/sam4e.dtsi, so it would not be as consistent to have it in overlay (and I like it more because it allows to keep the overlay level more end-user-friendly). |
pdgendt
approved these changes
Feb 25, 2025
nandojve
approved these changes
Feb 28, 2025
fabiobaltieri
added
the
Trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gpio header is missing, which will lead to failures when declaring GPIO down the line in board overlays.