-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
twister: setup logging per process, fix logging on macos #86240
twister: setup logging per process, fix logging on macos #86240
Conversation
@LukaszMrugala can you help with the pytest mocking here, not sure how to resolve this. |
Seems like the Windows build had the same issue and also work now. |
oh yeah, that is good. suprised nobody noticed this before ;-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, verified that it improvers logging on windows
It fails Unit tests because in the Adding this piece of code to the test (L1533) fixes the problem (note that the pb.options.outdir = tmp_path
pb.options.log_file = None
pb.options.log_level = "DEBUG" |
does not work, can you please post a patch here |
be0b3e0
to
fa50754
Compare
|
fa50754
to
b7795a5
Compare
rebased |
Setup logging per process to fix issue on both mac and windows where handlers are not available to the processes. Fixes zephyrproject-rtos#86237 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
b7795a5
to
aa3d874
Compare
not sure why on MacOS it behaves differently, but this seems to fix the issue
Fixes #86237