fb: cfb: Remove unused argument from font API #85442
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes introduced in zephyrproject-rtos#67881 not support fonts whose heights are not integer multiples of 8. This commit removes the old restriction. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add native_sim/native/64 to make it easier to run tests in a 64-bit ubuntu environment. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Previously, characters not present in the font were replaced with a space character. It has problem if the space character font is not trasnparent data. This change make they will be drawn with zero data instead. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
CHARACTER_FRAMEBUFFER_SHELL_DRIVER_NAME is not used. Remove it. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
cfb_remove_unused_arg
branch
from
f633281 to
2da50b0
Compare
soburi
changed the title
`cfb_get_font_size` and `cfb_get_numof_fonts` take a `const struct driver *` as a first argument, but not use it. Remove the argument and clean up related sources. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
cfb_remove_unused_arg
branch
from
2da50b0 to
3541af2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfb_get_font_sizeandcfb_get_numof_fontstake aconst struct driver *as a first argument, but not use it.Remove the argument and clean up related sources.