drivers: dma: silabs: Implementation of chan_filter and chan_release API with DMADRV functions. #85402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_silabs
DNM (manifest)
Martinhoff-maker
force-pushed
the
silabs_ldma_dmadrv_patch
branch
from
082592b to
eca294d
Compare
zephyrbot
requested review from
jerome-pouiller,
jhedberg,
mnkp,
rettichschnidi,
teburd and
yonsch
asmellby
previously approved these changes
Feb 11, 2025
Martinhoff-maker
force-pushed
the
silabs_ldma_dmadrv_patch
branch
from
eca294d to
8741763
Compare
zephyrbot
removed
the
DNM (manifest)
teburd
previously approved these changes
Feb 11, 2025
| @@ -502,7 +513,9 @@ static DEVICE_API(dma, dma_funcs) = { | |||
| .config = dma_silabs_configure, | |||
| .start = dma_silabs_start, | |||
| .stop = dma_silabs_stop, | |||
| .get_status = dma_silabs_get_status | |||
| .get_status = dma_silabs_get_status, | |||
There was a problem hiding this comment.
Please review and ensure the requirements have been met for these APIs, I have no insight into the HAL implementation of these functions so I can't definitively say if the requirements have been met.
Update hal_silabs to include emdrv/dmadrv. Signed-off-by: Martin Hoff <martin.hoff@silabs.com>
Update Cmake to include hal EMDRV header It also adds dmadrv source when CONFIG_SOC_GECKO_LDMA is selected Signed-off-by: Martin Hoff <martin.hoff@silabs.com>
Implementation of chan_filter and chan_release allows to maintain synchronization about DMA channel allocation between hal DMA driver and zephyr DMA driver. Signed-off-by: Martin Hoff <martin.hoff@silabs.com>
Martinhoff-maker
force-pushed
the
silabs_ldma_dmadrv_patch
branch
from
8741763 to
1b2d653
Compare
jhedberg
approved these changes
Feb 12, 2025
asmellby
approved these changes
Feb 12, 2025
teburd
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this patch is to maintain synchronization on DMA channel allocation between HAL DMA driver and Zephyr Silabs DMA driver.