Drop CAN from nRF9280 #85307
Merged
Drop CAN from nRF9280 #85307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
carlescufi
previously approved these changes
Feb 6, 2025
fabiobaltieri
previously approved these changes
Feb 7, 2025
fabiobaltieri
added
the
Trivial
kartben
requested changes
Feb 7, 2025
|
What Ben wrote above |
gmarull
dismissed stale reviews from fabiobaltieri and carlescufi
via
f3a6cff
kartben
previously approved these changes
Feb 7, 2025
fabiobaltieri
previously approved these changes
Feb 7, 2025
anangl
previously approved these changes
Feb 7, 2025
henrikbrixandersen
previously approved these changes
Feb 10, 2025
|
Hey, looking at this again, I think it may indeed also need an exclude on that test in --- a/tests/kernel/gen_isr_table/testcase.yaml
+++ b/tests/kernel/gen_isr_table/testcase.yaml
@@ -72,6 +72,7 @@ tests:
platform_exclude:
- m2gl025_miv
- adp_xc7k/ae350
+ - nrf9280pdk/nrf9280/cpuppr
filter: CONFIG_RISCV_PRIVILEGED
extra_configs:
- CONFIG_GEN_IRQ_VECTOR_TABLE=y@gmarull can you look into it? |
gmarull
dismissed stale reviews from henrikbrixandersen, anangl, fabiobaltieri, and kartben
via
f79765e
anangl
previously approved these changes
Feb 12, 2025
kartben
previously approved these changes
Feb 12, 2025
fabiobaltieri
previously approved these changes
Feb 12, 2025
henrikbrixandersen
previously approved these changes
Feb 12, 2025
CAN is not supported yet, so remove it from the board for now. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
CAN is not ready yet for this platform (clock control drivers). So remove the nodes for now. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
First, SoC is not supported, but when I tried to add it, build results in RAM overflow of ~10K. Excluding the platform for now, so CI is happy. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
gmarull
dismissed stale reviews from henrikbrixandersen, fabiobaltieri, kartben, and anangl
via
2e123b9
gmarull
force-pushed
the
nrf92-no-can
branch
from
f79765e to
2e123b9
Compare
gmarull
requested review from
fabiobaltieri,
anangl,
henrikbrixandersen and
kartben
kartben
approved these changes
Feb 13, 2025
anangl
approved these changes
Feb 13, 2025
henrikbrixandersen
approved these changes
Feb 13, 2025
fabiobaltieri
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAN is not ready yet for this SoC, so remove it for now.
Fixes #85065