fb: cfb: Supporting multiple display #68260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
force-pushed
the
cfb_support_multidisplay
branch
2 times, most recently
from
236493d to
5f3bcb1
Compare
zephyrbot
added
area: Display
Release Notes
zephyrbot
requested review from
henrikbrixandersen,
jfischer-no,
kartben,
MaureenHelm and
nashif
henrikbrixandersen
requested changes
Feb 24, 2024
doc/releases/migration-guide-3.6.rst
Outdated
Comment on lines
468
to
469
| CFB | ||
| === |
There was a problem hiding this comment.
This needs to go into the migration guide for v3.7.0 instead.
There was a problem hiding this comment.
Sorry for my late response.
Update done.
soburi
force-pushed
the
cfb_support_multidisplay
branch
from
5f3bcb1 to
9cc5338
Compare
soburi
force-pushed
the
cfb_support_multidisplay
branch
2 times, most recently
from
922c789 to
dc35fe4
Compare
soburi
force-pushed
the
cfb_support_multidisplay
branch
4 times, most recently
from
51ccabe to
48773e7
Compare
soburi
force-pushed
the
cfb_support_multidisplay
branch
3 times, most recently
from
2d42a93 to
5c2eefe
Compare
soburi
force-pushed
the
cfb_support_multidisplay
branch
2 times, most recently
from
8099533 to
48e9e48
Compare
This was referenced May 2, 2024
soburi
force-pushed
the
cfb_support_multidisplay
branch
from
48e9e48 to
3d41b9e
Compare
The logic introduced in zephyrproject-rtos#67881 can also handle fonts with heights other than integer multiple of 8. I remove the restriction. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add test cases for 1x1 and 11x13 fonts. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Change the arguments of `cfb_invert_area`, `cfb_print`, and `cfb_draw_(point|line|rect)`, which used unsigned integers to specify coordinates to signed integers. This is because coordinate calculations are usually based on real numbers, so it is difficult to use unless negative numbers are accepted. We clip drawings outside the drawable area on the implementation side. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
`cfb_get_font_size` and `cfb_get_numof_fonts` take a `const struct driver *` as a first argument, but not use it. Remove the argument and clean up related sources. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
There are three major changes. - Introducing `struct cfb_display` - Changed the argument `struct device *` to `struct cfb_framebuffer *` - Rename APIs starting with `cfb_framebuffer_*` Introduces struct cfb_display as a data structure to represent the display. As a result, it is now possible to create multiple pieces of data managed using a single static variable in previous implementations, making it possible to handle multiple displays. The old `struct cfb_framebuffer` remains but is now part of the `struct cfb_display` data structure. You can get cfb_framebuffer from cfb_display using the added API `cfb_display_get_framebuffer`. All places where a `struct device *` argument was passed to specify the target will be replaced with a `struct cfb_framebuffer *`. In line with this, API names starting with `cfb_framebuffer_*`, which were redundant and inconsistent names, will remove `_framebuffer` and change to `cfb_*` . Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add `display select` command to select display. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add a note about the changes of CFB(Character framebuffer) APIs. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
cfb_support_multidisplay
branch
from
3d41b9e to
dc2c64a
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multi-display. This change affects APIs widely.
I also make some API improvements.
(Removal of font size restrictions, Function argument signedness changes, Remove needless arguments from font APIs)
struct cfb_displaystruct device *tostruct cfb_framebuffer *cfb_framebuffer_*Introduces struct cfb_display as a data structure to represent the display.
As a result, it is now possible to create multiple pieces of data managed
using a single static variable in previous implementations,
making it possible to handle multiple displays.
The old
struct cfb_framebufferremains but is now part of thestruct cfb_displaydata structure.You can get cfb_framebuffer from cfb_display using the added API
cfb_display_get_framebuffer.All places where a
struct device *argument was passed to specify thetarget will be replaced with a
struct cfb_framebuffer *.In line with this, API names starting with
cfb_framebuffer_*,which were redundant and inconsistent names, will remove
_framebufferand change tocfb_*.Related API and implementation improvement have also been committed.
cfb_get_font_sizecfb_get_numof_fontscfb_invert_areacfb_printcfb_draw_point(cfb_position)cfb_draw_linecfb_draw_rectThis PR is part of a series of CFB enhancements (second of four #72177).
I would appreciate it if you could check the #67881 part first.