Ensure that correct libc headers are pulled by libstdc++ builds #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
added
ci-macos-aarch64
|
Initial test result: https://github.com/zephyrproject-rtos/sdk-ng/actions/runs/10992244350 This managed to fix the However, there are still more problems with the Canadian cross toolchain builds ( |
More detailed analysis on the symptom: #760 (comment) |
stephanosio
changed the title
This commit pulls in the crosstool-ng patch that fixes the wrong libstdc++ C library header path, specified using `--with-headers` argument, for additional libc variants such as newlib-nano and picolibc. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
GCC was adding the libc header directories to the target include search path only when building non-Canadian cross compilers, which caused wrong libc (newlib) headers to be picked up by the libstdc++ builds for companion libcs such as newlib-nano and picolibc when building a Canadian cross compiler. This commit pulls in the GCC patch that ensures that the libc header directories are always added to the include search path, even when compiling a Canadian cross compiler. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
This reverts commit ac8acc2 because the non-Linux C++ build issue has been fixed. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
stephanosio
force-pushed
the
ctng_fix_libstdcxx_libc_inc_path
branch
from
689801f to
e05392d
Compare
|
Two additional patches, one in crosstool-ng and another in gcc, have been added fixing the problems described in #760 (comment) and #760 (comment). |
stephanosio
merged commit 41449a8
into
zephyrproject-rtos:main
149 of 178 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series pulls in the crosstool-ng and gcc patches that ensure correct libc headers are pulled by the libstdc++ builds for the companion libcs (newlib-nano and picolibc).
crosstool-ng PR: zephyrproject-rtos/crosstool-ng#29
gcc PR: zephyrproject-rtos/gcc#36
Fixes #760