Apply assorted Repo-Review suggestions #1705
Conversation
DimitriPapadopoulos
force-pushed
the
repo-review
branch
2 times, most recently
from
84d660a to
e8532d5
Compare
|
Hello @DimitriPapadopoulos! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-05-07 15:56:55 UTC |
DimitriPapadopoulos
force-pushed
the
repo-review
branch
8 times, most recently
from
7f34a7c to
8842e2a
Compare
DimitriPapadopoulos
force-pushed
the
repo-review
branch
6 times, most recently
from
b182873 to
10f725c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
=======================================
Coverage 99.98% 99.99%
=======================================
Files 38 38
Lines 14667 14580 -87
=======================================
- Hits 14665 14579 -86
+ Misses 2 1 -1
|
| @@ -2497,7 +2505,7 @@ def _cache_value(self, key: Path, value): | |||
| value_size = buffer_size(value) | |||
| # check size of the value against max size, as if the value itself exceeds max | |||
| # size then we are never going to cache it | |||
| if self._max_size is None or value_size <= self._max_size: | |||
| if self._max_size is None or value_size <= self._max_size: # type: ignore[redundant-expr] | |||
There was a problem hiding this comment.
self._max_size is initialised here:
Lines 2406 to 2408 in f58065b
and here:
Lines 2417 to 2420 in f58065b
In the first case self._max_size shouldn't be None, but then the typing system cannot prevent giving the max_size parameter the None value. In the second case, without typing, I don't understand why ruff thinks the self._max_size is None check is redundant.
Must have a minversion=, and must be at least 6 (first version to support pyproject.toml configuration).
log_cli_level should be set. This will allow logs to be displayed on failures.
xfail_strict should be set. You can manually specify if a check should be strict when setting each xfail.
--strict-config should be in addopts = [...]. This forces an error if a config setting is misspelled.
--strict-markers should be in addopts = [...]. This forces all markers to be specified in config, avoiding misspellings.
An explicit summary flag like -ra should be in addopts = [...] (print summary of all fails/errors).
Projects should group their updates to avoid extra PRs and stay in sync. This is now supported by dependabot since June 2023.
Use https://github.com/psf/black-pre-commit-mirror instead of https://github.com/psf/black in .pre-commit-config.yaml
Must have "ignore-without-code" in enable_error_code = [...]. This will force all skips in your project to include the error code, which makes them more readable, and avoids skipping something unintended.
Must have "redundant-expr" in enable_error_code = [...]. This helps catch useless lines of code, like checking the same condition twice.
Left operand of "or" is always false [redundant-expr]
Must have "truthy-bool" in enable_error_code = []. This catches mistakes in using a value as truthy if it cannot be falsey.
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
10f725c to
b109932
Compare
|
@DimitriPapadopoulos - thanks for moving your focus over to the |
Mostly stricter pytest and MyPy settings.
TODO: