Filter s3 rather than ABS

zarr-developers · Feb 15, 2024 · a14734a · a14734a
1 parent 43e6aaf
commit a14734a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
@@ -75,14 +75,14 @@ jobs:
       run: |
         # Skip ABS on 3.9, see https://github.com/zarr-developers/zarr-python/pull/1542/#issuecomment-1945557365 etc.
         if [[ "${{ matrix.python-version }}" == '3.9' ]]; then
-            echo "ZARR_TEST_ABS=0" >> "$GITHUB_ENV"
+            FILTER='-k "not 'test_s3'"
         else
-            echo "ZARR_TEST_ABS=1" >> "$GITHUB_ENV"
+            FILTER=''
         fi
         conda activate zarr-env
         mkdir ~/blob_emulator
         azurite -l ~/blob_emulator --debug debug.log 2>&1 > stdouterr.log &
-        pytest --cov=zarr --cov-config=pyproject.toml --doctest-plus --cov-report xml --cov=./ --timeout=300
+        pytest --cov=zarr --cov-config=pyproject.toml --doctest-plus --cov-report xml --cov=./ --timeout=300 ${FILTER}
     - uses: codecov/codecov-action@v3
       with:
         token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos

diff --git a/.github/workflows/windows-testing.yml b/.github/workflows/windows-testing.yml
@@ -47,14 +47,14 @@ jobs:
         run: |
           # Skip ABS on 3.9, see https://github.com/zarr-developers/zarr-python/pull/1542/#issuecomment-1945557365 etc.
           if [[ "${{ matrix.python-version }}" == '3.9' ]]; then
-              echo "ZARR_TEST_ABS=0" >> "$GITHUB_ENV"
+            FILTER='-k "not 'test_s3'"
           else
-              echo "ZARR_TEST_ABS=1" >> "$GITHUB_ENV"
+            FILTER=''
           fi
           conda activate zarr-env
           mkdir ~/blob_emulator
           azurite -l ~/blob_emulator --debug debug.log 2>&1 > stdouterr.log &
-          pytest -sv --timeout=300
+          pytest -sv --timeout=300 ${FILTER}
         env:
           ZARR_V3_EXPERIMENTAL_API: 1
           ZARR_V3_SHARDING: 1