-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't overwrite codec config values when set. #700
Don't overwrite codec config values when set. #700
Conversation
A codec doesn't know where it is in the codec pipeline, so it cannot know whether `array_spec.dtype` should match `codec.dtype` or not.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (99.74%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
- Coverage 99.78% 99.74% -0.04%
==========================================
Files 63 63
Lines 2754 2753 -1
==========================================
- Hits 2748 2746 -2
- Misses 6 7 +1
|
I requested Norman for a review, since he originally wrote this code. Would be good to add some release notes too to explain what's fixed/changed for users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
Sweet can we release to unbreak Zar? |
i have no idea how to do a release but we should absolutely do one |
@dcherian I cut a release with this fix |
Fix is in upstream zarr-developers/numcodecs#700 Closes zarr-developers#2800
Fix is in upstream zarr-developers/numcodecs#700 Closes zarr-developers#2800
* Regression test for codec overwriting. Fix is in upstream zarr-developers/numcodecs#700 Closes #2800 * add note * fix skip
A codec doesn't know where it is in the codec pipeline, so it cannot know whether
array_spec.dtype
should matchcodec.dtype
or not. So I don't think it's appropriate to overwrite or even raise a warning or error.TODO: