-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded pcodec to 0.2 and used new ModeSpec configuration #544
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 99.91% 99.82% -0.09%
==========================================
Files 59 59
Lines 2319 2339 +20
==========================================
+ Hits 2317 2335 +18
- Misses 2 4 +2
|
It seems the lines the coverage report is complaining about are deliberately unreachable (with correct mypy typing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @mwlon!
My suggestion should fix the coverage.
Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
…lopers#544) * Upgraded pcodec to 0.2 and used new ModeSpec configuration * test coverage fix Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com> * actually test the line since it seems there's no way around it * fix pre-commit --------- Co-authored-by: Norman Rzepka <code@normanrz.com> Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
Upgraded Pcodec to 0.2. The main API change is replacement of individual mode specs with a single spec for all modes.