Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to zarr-v3-compatible released version of Kerchunk (0.2.8) #412

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Feb 1, 2025

Long-awaited part of #392, as it allows us to pin zarr-python>=3!

cc @mpiannucci the warning in the icechunk docs can be updated now (though virtualizarr still needs to be fixed to work with the latest version of icechunk).

  • Closes part of Planning explicit dependency on Zarr v3 #392
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@TomNicholas TomNicholas added Kerchunk Relating to the kerchunk library / specification itself dependencies Updates a dependency labels Feb 1, 2025
@TomNicholas
Copy link
Member Author

TomNicholas commented Feb 1, 2025

We need kerchunk to be on conda for the CI to work https://github.com/conda-forge/kerchunk-feedstock @martindurant

@martindurant
Copy link
Member

The bot should pick it up later today.

@martindurant
Copy link
Member

conda forge PR is merged, artefact should be available soon.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (83a6f10) to head (eb494cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   77.81%   84.17%   +6.36%     
==========================================
  Files          31       31              
  Lines        1839     1839              
==========================================
+ Hits         1431     1548     +117     
+ Misses        408      291     -117     

see 8 files with indirect coverage changes

@TomNicholas
Copy link
Member Author

Only failure is an icechunk one which also occurs on main (and I've mentioned it upstream earth-mover/icechunk#665 (comment)) so I will merge this now.

Thank so much @martindurant !

@TomNicholas TomNicholas merged commit 14f58ba into main Feb 3, 2025
11 of 12 checks passed
@TomNicholas TomNicholas deleted the kerchunk_0.2.8 branch February 3, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency Kerchunk Relating to the kerchunk library / specification itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants