New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce txn sender skeleton #293

Merged

dartdart26 merged 3 commits into main from petar/txn-sender

Feb 12, 2025

Collaborator

dartdart26 commented Feb 5, 2025 •

edited

Loading

Initial skeleton for the transaction sender. Still work in progress, but
it shows minimal implementations of:

error handling
verify proof response transactions

dartdart26 self-assigned this

dartdart26 marked this pull request as draft

February 5, 2025 15:56

dartdart26 requested review from goshawk-3 and rudy-6-4

February 5, 2025 15:56

dartdart26 force-pushed the petar/txn-sender branch 7 times, most recently from c2422a6 to 6fe523c Compare

February 6, 2025 14:49

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/cargo-tests.yml Fixed Show resolved Hide resolved

dartdart26 force-pushed the petar/txn-sender branch from 6fe523c to a2a7eb0 Compare

February 7, 2025 09:03

cla-bot bot added the cla-signed label

dartdart26 force-pushed the petar/txn-sender branch 7 times, most recently from ada9e27 to 5eb33bc Compare

February 10, 2025 17:01

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/transaction-sender/src/lib.rs Outdated Show resolved Hide resolved

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/transaction-sender/src/lib.rs Outdated Show resolved Hide resolved

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/transaction-sender/src/lib.rs Outdated Show resolved Hide resolved

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/transaction-sender/src/lib.rs Outdated Show resolved Hide resolved

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/transaction-sender/src/lib.rs Outdated Show resolved Hide resolved

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/transaction-sender/src/lib.rs Outdated Show resolved Hide resolved

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/transaction-sender/src/lib.rs Outdated Show resolved Hide resolved

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/transaction-sender/src/lib.rs Outdated Show resolved Hide resolved

rudy-6-4 reviewed

View reviewed changes

fhevm-engine/rust-toolchain.toml Show resolved Hide resolved

rudy-6-4 approved these changes

View reviewed changes

Contributor

rudy-6-4 left a comment

Lots of questions but nothing blocking.

dartdart26 force-pushed the petar/txn-sender branch 6 times, most recently from b8f9cb7 to 1775bee Compare

February 12, 2025 10:25


          feat: introduce txn sender skeleton

Initial skeleton for the transaction sender. Still work in progress, but
it shows minimal implementations of:
 * error handling
 * verify proof response transactions

dartdart26 force-pushed the petar/txn-sender branch from 1775bee to 4709532 Compare

February 12, 2025 10:33

dartdart26 changed the title ~~feat: introduce txn sender~~ feat: introduce txn sender skeleton

dartdart26 marked this pull request as ready for review

February 12, 2025 10:34

goshawk-3 approved these changes

View reviewed changes

Contributor

goshawk-3 left a comment

LGTM (just a few nitpicks).
Maybe adding some logs here and there (info, debug!) could be also helpful.

fhevm-engine/transaction-sender/src/ops/verify_proofs.rs Outdated Show resolved Hide resolved

fhevm-engine/transaction-sender/tests/integration_test.rs Show resolved Hide resolved

fhevm-engine/transaction-sender/src/ops/verify_proofs.rs Show resolved Hide resolved

fhevm-engine/transaction-sender/src/transaction_sender.rs Outdated Show resolved Hide resolved

fhevm-engine/transaction-sender/src/ops/verify_proofs.rs Show resolved Hide resolved

dartdart26 added 2 commits

February 12, 2025 14:59


          chore: fix clippy warnings

196d944


          chore: txn processing in own fn

65f12e5

dartdart26 merged commit 687ed14 into main

9 checks passed

dartdart26 deleted the petar/txn-sender branch

February 12, 2025 13:30

dartdart26 mentioned this pull request

Implement TxnSender for Input Proof txns from the Coprocessor to the L2 GW #272

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels