Modified the skipping db_queries warning to be more generic. #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shubham-yb
reviewed
Jan 29, 2025
| @@ -214,7 +214,7 @@ main() { | |||
|
|
|||
| log "INFO" "argument pgss_enabled=$pgss_enabled" | |||
| if [[ "$pgss_enabled" == "false" ]]; then | |||
| print_and_log "WARN" "Skipping $script_action: argument pgss_enabled is set as false" | |||
| print_and_log "WARN" "Skipping $script_action: pg_stat_statements are not enabled." | |||
There was a problem hiding this comment.
nit: pg_stat_statements extension is not enabled
There was a problem hiding this comment.
We need to update tar.gz file if any of the gather related file is updated in code - yb-voyager/src/srcdb/data/gather-assessment-metadata.tar.gz
There was a problem hiding this comment.
There was a problem hiding this comment.
I have added the changes to the tar.gz file
sanyamsinghal
approved these changes
Jan 29, 2025
atharva-kurhade-yb
force-pushed
the
atharva/rewording_skipping_db_queries_warning
branch
2 times, most recently
from
feac22a to
6433b65
Compare
|
Also ran a Jenkins Pipeline to test Oracle tests:- |
atharva-kurhade-yb
force-pushed
the
atharva/rewording_skipping_db_queries_warning
branch
from
6433b65 to
59f5d86
Compare
…rithm (#1725) - updated PG and Oracle tests for expected values in the report * Updated gather-assessment-metadata.tar.gz
atharva-kurhade-yb
deleted the
atharva/rewording_skipping_db_queries_warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Modified the skipping db_queries warning to be more generic.
Describe if there are any user-facing changes
How was this pull request tested?
Does your PR have changes that can cause upgrade issues?