[DB-13678] Assess Migration command guardrails check for pgss extension properly loaded or not in source db #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sanyamsinghal
commented
Nov 28, 2024
sanyamsinghal
commented
- doing SELECT query on pg_stat_statements view and comparing the error message
yb-voyager/src/srcdb/postgres.go
Outdated
| // so instead of getting current_settings(), executing SELECT query on pg_stat_statements view | ||
| // 3. check if its properly installed/loaded without any extra permissions | ||
| _, err = pg.db.Exec(queryCheckPgssLoaded) | ||
| if err != nil && strings.Contains(err.Error(), "pg_stat_statements must be loaded via shared_preload_libraries") { |
There was a problem hiding this comment.
nit: error msg constant SHARED_PRELOAD_LIBRARY_ERROR
yb-voyager/src/srcdb/postgres.go
Outdated
| @@ -1166,7 +1166,7 @@ const ( | |||
| JOIN pg_namespace n ON e.extnamespace = n.oid | |||
| WHERE e.extname = 'pg_stat_statements'` | |||
|
|
|||
| querySharedPreloadLibraries = `SELECT current_setting('shared_preload_libraries')` | |||
| queryCheckPgssLoaded = `SELECT query from pg_stat_statements LIMIT 1` | |||
There was a problem hiding this comment.
schema of pgss table in case it's in non_public.
…on properly loaded or not in source db - doing SELECT query on pg_stat_statements view and comparing the error message
sanyamsinghal
force-pushed
the
sanyam/pgss-preload
branch
from
d09c2e6 to
d2234a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.