Review comments: adding quotes, assigning impact level etc...

migtests/tests/pg/omnibus/expected_files/expected_schema_analysis_report.json

@@ -216,7 +216,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "INDEX",
             "ObjectName": "hidx ON extension_example.testhstore",
-            "Reason": "The schema contains an index with an access method \"GIST\" which is not supported in YugabyteDB.",
+            "Reason": "The schema contains an index with an access method 'GIST' which is not supported in YugabyteDB.",
             "SqlStatement": "CREATE INDEX hidx ON extension_example.testhstore USING gist (h extension_example.gist_hstore_ops (siglen='32'));",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/omnibus/export-dir/schema/tables/INDEXES_table.sql",
             "Suggestion": "",
@@ -228,7 +228,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "INDEX",
             "ObjectName": "idx_1 ON composite_type_examples.ordinary_table",
-            "Reason": "Indexes on columns with complex data types like user_defined_type are not yet supported in YugabyteDB",
+            "Reason": "Indexes on columns with complex data types like 'user_defined_type' are not yet supported in YugabyteDB",
             "SqlStatement": "CREATE INDEX idx_1 ON composite_type_examples.ordinary_table USING btree (basic_);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/omnibus/export-dir/schema/tables/INDEXES_table.sql",
             "Suggestion": "Refer to the docs link for the workaround",

migtests/tests/pg/osm/expected_files/expected_schema_analysis_report.json

@@ -70,7 +70,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "INDEX",
             "ObjectName": "changeset_geom_gist ON public.osm_changeset",
-            "Reason": "The schema contains an index with an access method \"GIST\" which is not supported in YugabyteDB.",
+            "Reason": "The schema contains an index with an access method 'GIST' which is not supported in YugabyteDB.",
             "SqlStatement": "CREATE INDEX changeset_geom_gist ON public.osm_changeset USING gist (geom);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/osm/export-dir/schema/tables/INDEXES_table.sql",
             "Suggestion": "",

migtests/tests/pg/sakila/expected_files/expected_schema_analysis_report.json

@@ -165,7 +165,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "INDEX",
             "ObjectName": "film_fulltext_idx ON public.film",
-            "Reason": "The schema contains an index with an access method \"GIST\" which is not supported in YugabyteDB.",
+            "Reason": "The schema contains an index with an access method 'GIST' which is not supported in YugabyteDB.",
             "SqlStatement": "CREATE INDEX film_fulltext_idx ON public.film USING gist (fulltext);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/INDEXES_table.sql",
             "Suggestion": "",

yb-voyager/cmd/analyzeSchema.go

@@ -1255,6 +1255,7 @@ func packAndSendAnalyzeSchemaPayload(status string, errorMsg string) {
 			if strings.HasPrefix(issue.Reason, sensitiveReason) {
 				issue.Reason = sensitiveReason
 			} else {
+				// TODO: should we just start sending issue type/name here instead of obfuscating the reason since that is anyways static
 				match, err := utils.MatchesFormatString(sensitiveReason, issue.Reason)
 				if match {
 					issue.Reason, err = utils.ObfuscateFormatDetails(sensitiveReason, issue.Reason, constants.OBFUSCATE_STRING)

yb-voyager/src/query/queryissue/constants.go

@@ -122,7 +122,7 @@ const (
 	// for DDLs
 	STORED_GENERATED_COLUMNS_ISSUE_DESCRIPTION                       = "Stored generated columns are not supported in YugabyteDB. Detected columns are (%s)."
 	UNLOGGED_TABLES_ISSUE_DESCRIPTION                                = "UNLOGGED tables are not yet supported in YugabyteDB"
-	UNSUPPORTED_INDEX_METHOD_DESCRIPTION                             = "The schema contains an index with an access method %q which is not supported in YugabyteDB."
+	UNSUPPORTED_INDEX_METHOD_DESCRIPTION                             = "The schema contains an index with an access method '%s' which is not supported in YugabyteDB."
 	STORAGE_PARAMETERS_ISSUE_DESCRIPTION                             = "Storage parameters in tables, indexes, and constraints are not yet supported in YugabyteDB"
 	ALTER_TABLE_SET_COLUMN_ATTRIBUTE_ISSUE_DESCRIPTION               = "ALTER TABLE .. ALTER COLUMN .. SET ( attribute = value ) is not yet supported in YugabyteDB"
 	ALTER_TABLE_CLUSTER_ON_ISSUE_DESCRIPTION                         = "ALTER TABLE CLUSTER is not yet supported in YugabyteDB"
@@ -145,8 +145,8 @@ const (
 	UNSUPPORTED_DATATYPE_ISSUE_DESCRIPTION                           = "Datatype not yet supported in YugabyteDB. Affected column: %s and type: %s."
 	UNSUPPORTED_DATATYPE_LIVE_MIGRATION_ISSUE_DESCRIPTION            = "Datatype not yet supported by voyager in live migration. Affected column: %s and type: %s. These columns will be excluded when exporting and importing data in live migration workflows."
 	UNSUPPORTED_DATATYPE_LIVE_MIGRATION_WITH_FF_FB_ISSUE_DESCRIPTION = "Datatype not yet supported by voyager in live migration with fall-forward/fallback. Affected column: %s and type: %s. These columns will be excluded when exporting and importing data in live migration workflows."
-	PK_UK_ON_COMPLEX_DATATYPE_ISSUE_DESCRIPTION                      = "Primary key and Unique constraints on columns with complex data types like %s are not yet supported in YugabyteDB."
-	INDEX_ON_COMPLEX_DATATYPE_ISSUE_DESCRIPTION                      = "Indexes on columns with complex data types like %s are not yet supported in YugabyteDB"
+	PK_UK_ON_COMPLEX_DATATYPE_ISSUE_DESCRIPTION                      = "Primary key and Unique constraints on columns with complex data types like '%s' are not yet supported in YugabyteDB."
+	INDEX_ON_COMPLEX_DATATYPE_ISSUE_DESCRIPTION                      = "Indexes on columns with complex data types like '%s' are not yet supported in YugabyteDB"
 	FOREIGN_TABLE_ISSUE_DESCRIPTION                                  = "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager. These should be manually created to make the foreign tables work."
 	INHERITANCE_ISSUE_DESCRIPTION                                    = "Table inheritance is not yet supported in YugabyteDB"
 	REFERENCED_TYPE_DECLARATION_ISSUE_DESCRIPTION                    = "Referencing the type of a column instead of the actual type name is not supported in YugabyteDB"

yb-voyager/src/query/queryissue/issues_ddl.go

@@ -351,7 +351,7 @@ func NewXIDDatatypeIssue(objectType string, objectName string, sqlStatement stri
 var postgisDatatypeIssue = issue.Issue{
 	Type:        POSTGIS_DATATYPE,
 	Name:        "Unsupported datatype - POSTGIS",
-	Impact:      constants.IMPACT_LEVEL_1, // Ques: Should it be IMPACT_LEVEL_3 like other unsupported datatypes?
+	Impact:      constants.IMPACT_LEVEL_3,
 	Description: POSTGIS_DATATYPE_ISSUE_DESCRIPTION,
 	GH:          "https://github.com/yugabyte/yugabyte-db/issues/11323",
 	DocsLink:    "https://docs.yugabyte.com/preview/yugabyte-voyager/known-issues/postgresql/#unsupported-datatypes-by-yugabytedb",
@@ -366,7 +366,7 @@ func NewPostGisDatatypeIssue(objectType string, objectName string, sqlStatement
 var unsupportedDatatypeIssue = issue.Issue{
 	Type:        UNSUPPORTED_DATATYPE,
 	Name:        "Unsupported datatype",
-	Impact:      constants.IMPACT_LEVEL_1, // Ques: Should it be IMPACT_LEVEL_3 like other unsupported datatypes?
+	Impact:      constants.IMPACT_LEVEL_3,
 	Description: UNSUPPORTED_DATATYPE_ISSUE_DESCRIPTION,
 	GH:          "https://github.com/yugabyte/yb-voyager/issues/1731",
 	DocsLink:    "https://docs.yugabyte.com/preview/yugabyte-voyager/known-issues/postgresql/#unsupported-datatypes-by-yugabytedb",