Use codecheck

bin/build_clang.sh

@@ -1,10 +1,11 @@
 #!/usr/bin/env bash
 
 set -euo pipefail
-. "${BASH_SOURCE%/*}/common.sh"
+# shellcheck source=bin/common.sh
+. "${BASH_SOURCE[0]%/*}/common.sh"
 
 yb_activate_virtualenv "$build_clang_project_root"
 
 set_pythonpath
 
-python3 "$build_clang_project_root/src/build_clang/build_clang_main.py" "$@"
+python3 "$build_clang_project_root/src/build_clang/build_clang_main.py" "$@"

bin/check.sh

@@ -1,10 +1,10 @@
 #!/usr/bin/env bash
 
 set -euo pipefail
-. "${BASH_SOURCE%/*}/common.sh"
 
-yb_activate_virtualenv "$build_clang_project_root"
+# shellcheck source=bin/common.sh
+. "${BASH_SOURCE[0]%/*}/common.sh"
 
-set_pythonpath
+yb_activate_virtualenv "$build_clang_project_root"
 
-"$build_clang_project_root/src/build_clang/check_python_code.py"
+codecheck

bin/common.sh

@@ -1,18 +1,21 @@
+#!/usr/bin/env bash
+
 set -euo pipefail
 
 set_pythonpath() {
   export PYTHONPATH=$build_clang_project_root/src
 }
 
-if [[ $BASH_SOURCE == $0 ]]; then
-  echo "$BASH_SOURCE must be sourced, not executed" >&2
+if [[ ${BASH_SOURCE[0]} == "$0" ]]; then
+  echo "${BASH_SOURCE[0]} must be sourced, not executed" >&2
   exit 1
 fi
 
-build_clang_project_root=$( cd "${BASH_SOURCE%/*}" && cd .. && pwd )
+build_clang_project_root=$( cd "${BASH_SOURCE[0]%/*}" && cd .. && pwd )
 if [[ ! -d $build_clang_project_root/yugabyte-bash-common ||
       -z "$( ls -A "$build_clang_project_root/yugabyte-bash-common" )" ]]; then
   ( cd "$build_clang_project_root"; git submodule update --init --recursive )
 fi
 
+# shellcheck source=yugabyte-bash-common/src/yugabyte-bash-common.sh
 . "$build_clang_project_root/yugabyte-bash-common/src/yugabyte-bash-common.sh"

requirements.txt

@@ -2,3 +2,4 @@ mypy
 pycodestyle
 requests
 PyGithub
+codecheck

src/build_clang/build_clang_main.py

@@ -203,7 +203,6 @@ def get_llvm_cmake_variables(self) -> Dict[str, str]:
             LLVM_TARGETS_TO_BUILD='X86',
 
             CLANG_DEFAULT_CXX_STDLIB='libc++',
-            #CLANG_DEFAULT_LINKER='lld',
 
             BUILD_SHARED_LIBS=ON,