Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of substance designer integration #1

Merged
merged 26 commits into from
Jan 21, 2025
Merged

Implementation of substance designer integration #1

merged 26 commits into from
Jan 21, 2025

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Jan 16, 2025 •
edited
Loading

Changelog Description

Implementation of substance designer integration

  • Workfile Load/Save. Get current file etc.
  • Container data
  • Instance Data
  • Load Image(textures) for existing project
  • Publish Image(textures) -> (Part of the TextureSet product)
  • Publish Workfile
  • Publish Sbsar (Can be part of the textureSet product) Solve in Implementation of sbsar product type #3
  • Callback to create Package Project for users

Maybe nice to have:

  • Load/Publish MDL
  • Load/Publish custom graph node
  • Publish textures/sbsar supporting for multiple graphs.

Additional review information

Please test along with: ynput/ayon-applications#50 and ynput/ayon-core#1089

  • Publishing colorspace data temporarily not supported in texture publish due to the limitation of the API
  • Custom Pattern for output is not supported due to the limitation of the API

Testing notes:

  1. Build and install addon with this branch in the ayon server along with the updated application and core addons mentioned above
  2. Launch Substance Designer

@moonyuet moonyuet requested review from BigRoy and LiborBatek January 16, 2025 09:12
@moonyuet moonyuet self-assigned this Jan 16, 2025
@moonyuet moonyuet added the type: feature Adding something new and exciting to the product label Jan 16, 2025
moonyuet added 21 commits January 16, 2025 18:09
@moonyuet
add ocio settings into ayon-settings
149c723
@moonyuet
implement the logic for context data and get_container
7fd279c
@moonyuet
drafting the loader plugins
e0425e4
@moonyuet
working on loading texture and imprinting system
e96bbed
@moonyuet
fix the container loading issue/texture loader implementation
8896a38
@moonyuet
implementing remove instances for texture loader
bc6f0e9
@moonyuet
linter issue
d70c3bc
@moonyuet
implement the collector for workfile product type
aba1ab7
@moonyuet
set up the instance data & template for workfile creator
5c58154
@moonyuet
add current context label into the ayon menu and version up workfile …
b127fe5 
…options into the ayon menu
@moonyuet
add increment workfile version into the workfile product
3097ce5
@moonyuet
improve the instance data and implement workfile publish
20520cc
@moonyuet
add save_workfile.py for workfile product type
c343ab7
@moonyuet
implement textureSet creator
f291728
@moonyuet
implement texture product type
b95d942
@moonyuet
add sbsar extractor
3b5c005
@moonyuet
extract texture tweak
b9d2bba
@moonyuet
fix the integrating asset issue
2d3b285
@moonyuet
improve the code
8de488e
@moonyuet
clean up the codes for the sbsar and ayon plugins
0e7b7f9
@moonyuet
fix the setting version bug of texture loader
7d08063
LiborBatek
LiborBatek reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have succesfully configured SDesigner within AYON and I was able to launch it via Ayon launcher but I couldnt navigate/find the AYON Menu with tools...

image

any thoughts?

@moonyuet
Copy link
Member Author

I have succesfully configured SDesigner within AYON and I was able to launch it via Ayon launcher but I couldnt navigate/find the AYON Menu with tools...

image

any thoughts?

Are you building and installing the addon with this branch?
You can also check on the console to see if anything errors out.
image

@LiborBatek LiborBatek self-requested a review January 21, 2025 10:41
LiborBatek
LiborBatek approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working nicely and been successfully tested! I was able to publish textureSet, Load Images in and Manage those too.
image

The core functionality is there and working properly.

@moonyuet moonyuet marked this pull request as ready for review January 21, 2025 11:05
@moonyuet moonyuet merged commit 229fb6a into develop Jan 21, 2025
1 check passed
@moonyuet moonyuet mentioned this pull request Jan 21, 2025
Open
@moonyuet
Copy link
Member Author

I merged this ticket first and continue working on the enhancement after the feedback.

@moonyuet moonyuet deleted the feature/initial_substance_designer_integration branch January 23, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

@BigRoy BigRoy Awaiting requested review from BigRoy

Assignees

@moonyuet moonyuet

Labels
type: feature Adding something new and exciting to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moonyuet @LiborBatek