Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
  • Loading branch information
3 people authored Oct 23, 2024
1 parent a331f56 commit 859db3e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
4 changes: 0 additions & 4 deletions client/ayon_hiero/api/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,6 @@ def install(self):
register_loader_plugin_path(LOAD_PATH)
register_creator_plugin_path(CREATE_PATH)

# register callback for switching publishable
pyblish.register_callback(
"instanceToggled", on_pyblish_instance_toggled)

# install menu
menu.menu_install()
menu.add_scripts_menu()
Expand Down
12 changes: 3 additions & 9 deletions client/ayon_hiero/api/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -616,13 +616,7 @@ class HieroCreator(Creator):
"""Creator class wrapper
"""

def apply_settings(self, project_settings):
hiero_create_settings = (
project_settings.get("hiero", {}).get("create")
)
self.presets = hiero_create_settings.get(
self.__class__.__name__, {}
)
settings_category = "hiero"

def create(self, subset_name, instance_data, pre_create_data):
# adding basic current context resolve objects
Expand All @@ -647,7 +641,7 @@ class PublishClip:
kwargs (optional): additional data needed for rename=True (presets)
Returns:
hiero.core.TrackItem: hiero track item object with pype tag
hiero.core.TrackItem: hiero track item object with AYON tag
"""
types = {
"shot": "shot",
Expand Down Expand Up @@ -917,7 +911,7 @@ def _convert_to_tag_data(self):

# add review track only to hero track
if hero_track and self.review_layer:
self.tag_data.update({"reviewTrack": self.review_layer})
self.tag_data["reviewTrack"] = self.review_layer
else:
self.tag_data.update({"reviewTrack": None})

Expand Down

0 comments on commit 859db3e

Please sign in to comment.