Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Folder thumbnails in Launcher, Workfiles tool, Loader in the Folder Widget. #1144

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Feb 12, 2025

Changelog Description

Show the folder thumbnails for the folder entries in the Folder Widget, making it how in the Launcher, Workfiles Tool, Loader, etc.

Additional info

Uses a background thread to retrieve the thumbnails to avoid large slow downs.

Just a prototype to show how it could be done.

image
image (16)
image (15)

A draft implementation for: #749
(However this does not show task thumbnails)

Testing notes:

  1. Run launcher/loader etc. and it should show thumbnails.

@BigRoy BigRoy added the community Issues and PRs coming from the community members label Feb 12, 2025
@BigRoy BigRoy self-assigned this Feb 12, 2025
@ynbot ynbot added size/S type: enhancement Improvement of existing functionality or minor addition labels Feb 12, 2025
@iLLiCiTiT
Copy link
Member

  1. Shouldn't we cache it on disk so each refresh does not re-download all thumbnails on project?
  2. Shoulnd't we use thumbnail_id on entities instead of using endpoint to get thumbnail by entity type and id -> which re-downloads the same thumbnail if is the same?
  3. I believe thumbnails should have their model for that, so it's managable at single place.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Feb 12, 2025

  1. Shouldn't we cache it on disk so each refresh does not re-download all thumbnails on project?

    1. Shoulnd't we use thumbnail_id on entities instead of using endpoint to get thumbnail by entity type and id -> which re-downloads the same thumbnail if is the same?

    2. I believe thumbnails should have their model for that, so it's managable at single place.

All valid questions - this was merely a prototype. I think, yes - optimization here is good.

Before that though - I wonder about how worth it that really is if e.g. no-one likes the UX this brings. E.g. currently entries without thumbnail are not expanded in the list - sometimes making an 'uneven' list which feels a bit cluttered, etc.

@iLLiCiTiT
Copy link
Member

Before that though - I wonder about how worth it that really is if e.g. no-one likes the UX this brings. E.g. currently entries without thumbnail are not expanded in the list - sometimes making an 'uneven' list which feels a bit cluttered, etc.

Agree that the UX is "not friendly", and I'm know to not be the person who can change that. But I can make it happen if someone comes with one 🙂 and I'll get hours to work on it.

@mkolar
Copy link
Member

mkolar commented Feb 13, 2025

Quite frankly there's not much point putting a lot of work into launcher right now as we're planning to replace it with a react UI anyways.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Feb 13, 2025

Quite frankly there's not much point putting a lot of work into launcher right now as we're planning to replace it with a react UI anyways.

Note that it isn't dedicated to launcher - it's implementing in the "Folder widget" which is used in launcher, but also in Loader, Workfiles tool inside DCCs, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants