name を入力できるように #28
Open
name を入力できるように #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 28, 2021
Open
Open
NMai-source
reviewed
Nov 30, 2021
| <rect key="frame" x="0.0" y="0.0" width="414" height="43.5"/> | ||
| <autoresizingMask key="autoresizingMask"/> | ||
| <subviews> | ||
| <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Period" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="d1t-YT-Wmb"> |
There was a problem hiding this comment.
@ykws
シミュレータ上でperiodのドラムロールが操作できませんでした。
There was a problem hiding this comment.
@NMai-source うーん、手元だと動きますね。
Simulator で ⌘+Rで録画できるので、再現を録画した動画ファイルを添付してもらっても良いでしょうか？
Simulator.Screen.Recording.-.iPhone.8.-.2021-12-02.at.22.47.26.mp4
There was a problem hiding this comment.
@ykws
録画しました。
分かりづらいですが、上から順にクリックしてperiodのドラムロールを表示しようとしています。
ご確認お願い致します。
Simulator.Screen.Recording.-.iPod.touch.7th.generation.-.2021-12-02.at.23.26.11.mp4
There was a problem hiding this comment.
@NMai-source なるほど、 Algorithm と Digits はタップするセルの色が変わりますが、 Period は変わっていないので、タップしても反応しない、という認識であってますか？
There was a problem hiding this comment.
@ykws
はい、タップしても反応しません。
fixes #14
ykws
force-pushed
the
feature/27-input-name
branch
from
73cb4bf to
2d1ae9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応内容
スクリーンショット