Global users aren't able to cast the vote on subwiki's poll

[petrenkonikita112263]

Prerequisites:

• XWiki instance 16.10.1.
• Installed globally (on the farm) Polls application v.2.3 (at the time this issue was filed)
• Trial license
• Created a normal user (member of XWikiAllGroup)
• Created subwiki that is open for global users

Step to reproduce:

1. Being logged as XWiki Admin, create any vote with the status Active
2. Make a vote
3. Log in as another user and try to vote

Actual result:
Global users can select options but aren't able to save their votes. The XWiki will return the error "Not allowed to vote!". The browser will have this request PUT http://localhost/xwiki/rest/wikis/test/spaces/XPoll/spaces/Test+Poll/pages/WebHome/xpoll, which returns a 403 status code.

Expected result:
Global users are able to save their votes.

[petrenkonikita112263]

This might be the issue with the voting method in a conditional statement.

application-xpoll/application-xpoll-api/src/main/java/com/xwiki/xpoll/internal/rest/DefaultXPollResource.java

Line 58 in bc470f7

public Response vote(String wikiName, String spaces, String pageName, Vote vote) throws XWikiRestException

Note that the issue is reproducible on XWiki 14.10, which uses old-core API. The reason why it's reproducable on higher versions, as the API was changed since 16.10.0+

Once I invited user into created subwiki that user can save the vote on created poll.

[KebabRonin]

This is the intended behavior. Since the user is not part of the subwiki, the user doesn't have edit rights and can't vote. They have to join first by joining from the Wiki Index or being added by Admin.

So the solution is to give the user edit rights on the poll page, either by joining the subwiki as mentioned above, or to change the user rights for the page/wiki to grant users from the main wiki XWikiAllGroup edit rights for the subwiki poll.

Maybe related to this improvement: #112.

[petrenkonikita112263]

thx @KebabRonin for checks and input

[snazare]

reopened as we misunderstood the issue. We need to allow users to vote even though they don't have edit rights. We should replace edit check with the user not being guest and having view right on the poll