Global users aren't able to cast the vote on subwiki's poll xwikisas#111

* Refactoring
KebabRonin · Feb 21, 2025 · 5966f72 · 5966f72
1 parent b39cb9d
commit 5966f72
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/...ation-xpoll-api/src/test/java/com/xwiki/xpoll/internal/rest/DefaultXPollResourceTest.java b/...ation-xpoll-api/src/test/java/com/xwiki/xpoll/internal/rest/DefaultXPollResourceTest.java
@@ -105,39 +105,31 @@ public void configure() throws Exception
     @Test
     void saveXPollAnswersWithEditRightTest() throws XWikiRestException
     {
-        when(this.contextualAuthorizationManager.hasAccess(eq(Right.VIEW), any(DocumentReference.class))).thenReturn(true);
-        when(this.contextualAuthorizationManager.hasAccess(eq(Right.EDIT), any(DocumentReference.class))).thenReturn(true);
-        when(this.xWikiContext.getUserReference()).thenReturn(userDocumentReference);
+        setMockUserRights(true, true, userDocumentReference);
         Response response = this.resource.vote("wiki", "space", "page", new Vote());
         assertEquals(Response.Status.OK.getStatusCode(), response.getStatus());
     }
 
     @Test
     void saveXPollAnswersWithoutEditRightTest() throws XWikiRestException
     {
-        when(this.contextualAuthorizationManager.hasAccess(eq(Right.VIEW), any(DocumentReference.class))).thenReturn(true);
-        when(this.contextualAuthorizationManager.hasAccess(eq(Right.EDIT), any(DocumentReference.class))).thenReturn(false);
-        when(this.xWikiContext.getUserReference()).thenReturn(userDocumentReference);
+        setMockUserRights(true, false, userDocumentReference);
         Response response = this.resource.vote("wiki", "space", "page", new Vote());
         assertEquals(Response.Status.OK.getStatusCode(), response.getStatus());
     }
 
     @Test
     void saveXPollAnswersWithoutViewRightTest() throws XWikiRestException
     {
-        when(this.contextualAuthorizationManager.hasAccess(eq(Right.VIEW), any(DocumentReference.class))).thenReturn(false);
-        when(this.contextualAuthorizationManager.hasAccess(eq(Right.EDIT), any(DocumentReference.class))).thenReturn(false);
-        when(this.xWikiContext.getUserReference()).thenReturn(userDocumentReference);
+        setMockUserRights(false, false, userDocumentReference);
         Response response = this.resource.vote("wiki", "space", "page", new Vote());
         assertEquals(Response.Status.FORBIDDEN.getStatusCode(), response.getStatus());
     }
 
     @Test
     void saveXPollAnswersLoggedOutTest() throws XWikiRestException
     {
-        when(this.contextualAuthorizationManager.hasAccess(eq(Right.VIEW), any(DocumentReference.class))).thenReturn(true);
-        when(this.contextualAuthorizationManager.hasAccess(eq(Right.EDIT), any(DocumentReference.class))).thenReturn(false);
-        when(this.xWikiContext.getUserReference()).thenReturn(null);
+        setMockUserRights(true, false, null);
         Response response = this.resource.vote("wiki", "space", "page", new Vote());
         assertEquals(Response.Status.FORBIDDEN.getStatusCode(), response.getStatus());
     }
@@ -146,8 +138,7 @@ void saveXPollAnswersLoggedOutTest() throws XWikiRestException
     void saveXPollButManagerThrowsException() throws XPollException, XWikiRestException
     {
         DocumentReference docRef = new DocumentReference("xwiki", "Main", "WebHome");
-        when(this.xWikiContext.getUserReference()).thenReturn(userDocumentReference);
-        when(this.contextualAuthorizationManager.hasAccess(Right.VIEW, docRef)).thenReturn(true);
+        setMockUserRights(true, false, userDocumentReference);
         when(this.serializer.serialize(null, new WikiReference("wiki"))).thenReturn("userIdentifier");
 
         Vote vote = new Vote();
@@ -157,4 +148,11 @@ void saveXPollButManagerThrowsException() throws XPollException, XWikiRestExcept
         Response response = resource.vote("xwiki", "Main", "WebHome", vote);
         assertEquals(Response.Status.NOT_FOUND.getStatusCode(), response.getStatus());
     }
+
+    private void setMockUserRights(boolean viewRight, boolean editRight, DocumentReference userReference)
+    {
+        when(this.contextualAuthorizationManager.hasAccess(eq(Right.VIEW), any(DocumentReference.class))).thenReturn(viewRight);
+        when(this.contextualAuthorizationManager.hasAccess(eq(Right.EDIT), any(DocumentReference.class))).thenReturn(editRight);
+        when(this.xWikiContext.getUserReference()).thenReturn(userReference);
+    }
 }