-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create health check for size of the log files #35 #36
Draft
ChiuchiuSorin
wants to merge
85
commits into
xwikisas:main
Choose a base branch
from
ChiuchiuSorin:health-check-logs-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Create health check for size of the log files #35 #36
ChiuchiuSorin
wants to merge
85
commits into
xwikisas:main
from
ChiuchiuSorin:health-check-logs-size
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the pom structure of the project
# Conflicts: # application-admintools-default/pom.xml # application-admintools-default/src/main/resources/META-INF/components.txt
- Created an interface and abstract class DataProvider for better generalization and future extension of the components that provide data. - Created templates for data gathering components.
Rewrited some of the comments and corrected some typos.
Code refactoring
- Removed the download logs endpoint - Added an endpoint for downloading a multiple files archive - Added function for data providers to return info json - Added script function to retrieve the context path
- added logs viewer endpoint - merged with config-info
* forgot to edit JS file
* Modified files exception handling
* Modified exception handling * Added comments
* Created a page to run the job * Created a page to access job progress * Created a page to display useful links * Modified jobFinishedMessage macro to adapt to healthCheck messages style * Created JS for handling job start request, page refresh, job restart and status display on refresh when the job is finnished * Created dashboard item to display job progress, log, start button and link to help page.
* Integrated JobRunner in JS * Refactored JS * Refactored HeallthCheck dashboard code * Refactored HealthCheckResources code
* Modified comments * Modified Exception and logger messages
* Code refactoring for filters handling
# Conflicts: # application-admintools-api/src/main/java/com/xwiki/admintools/ServerIdentifier.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/ConfigurationDataProvider.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/TomcatIdentifier.java # application-admintools-default/src/main/resources/META-INF/components.txt # application-admintools-default/src/main/resources/templates/configurationTemplate.vm # application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/ConfigurationDataProviderTest.java
* Merged with main branch
* Small UI modifications
…-check # Conflicts: # application-admintools-ui/src/main/resources/AdminTools/Code/AdminToolsJS.xml
* Added translations * Integrated transaltions in Java * Added MemoryHealthCheck
* Modified translations * Added unit tests * Added comments
# Conflicts: # application-admintools-api/pom.xml # application-admintools-default/src/main/java/com/xwiki/admintools/script/AdminToolsScriptService.java # application-admintools-default/src/main/resources/META-INF/components.txt # application-admintools-ui/src/main/resources/AdminTools/Code/AdminToolsJS.xml # application-admintools-ui/src/main/resources/AdminTools/Code/Macros.xml # application-admintools-ui/src/main/resources/AdminTools/Code/Translations.xml # application-admintools-ui/src/main/resources/AdminTools/WebHome.xml
* Merged main
* Refactored JavaScript, Macros, job resource and dashboard * Moved the code for health check inside a macro * Created tests for HealthCheckJob
* Modified translations * Added comments in default POM
# Conflicts: # application-admintools-ui/src/main/resources/AdminTools/Code/Macros.xml # application-admintools-ui/src/main/resources/AdminTools/Code/Translations.xml
* Refactored the way a component is found in the entire project * Refactored tests * Merged the security health checks * Added translations * Refactored Help links page * Replaced hidden inputs for data comunication between server and client with attributes * JS refactoring * job velocity refactoring * Replaced OperatingSystemMXBean for finding physical memory with JVM independent com.github.oshi * Removed the script for creating a request. The client will now only access the job runner script and will send the ID that will be used * Other minor modifications
# Conflicts: # application-admintools-default/src/main/resources/templates/configurationTemplate.vm # application-admintools-default/src/main/resources/templates/filesSectionTemplate.vm # application-admintools-default/src/main/resources/templates/securityTemplate.vm # application-admintools-ui/src/main/resources/AdminTools/Code/AdminToolsJS.xml # application-admintools-ui/src/main/resources/AdminTools/Code/Configuration.xml # application-admintools-ui/src/main/resources/AdminTools/Code/ConfigurationClass.xml # application-admintools-ui/src/main/resources/AdminTools/Code/Macros.xml # application-admintools-ui/src/main/resources/AdminTools/Code/Translations.xml # application-admintools-ui/src/main/resources/AdminTools/WebHome.xml
* Modified the test structure * Adpated health checks to the usage of HealthCheckResult * Added tests to be able to return a result for every tested data * Created HealthCheckMacros * Created macro for generating job status info * Created macros for displaying the HealthCheckresults in the UI * Added the posibility to extend a result in the UI to see a more detailed explanation or suggestion * Added coments * Addded and modified translations * Adapted tests and added new tests for the new classes * Other small modification in JS and backend
* Adapted the request for job.js in AdminToolsJs to be initialized only once * Added grouping for the job * Created function to generate the job id inside the script service * Refactored the help links * Refactored the HealthCheckMacros and HealthCheckResources
* Fixed missing CSS class selector
* Code refactoring
* Created a check for verifying the size of the logs folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new health check to verify if the server log files exceed a certain size.