Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User input validation for worker names and usernames #11

Merged
merged 7 commits into from
Jan 20, 2025
Merged

User input validation for worker names and usernames #11

merged 7 commits into from
Jan 20, 2025

Conversation

doug-jacob
Copy link
Contributor

@doug-jacob doug-jacob commented Jan 20, 2025 •
edited
Loading

  • any input the user chooses for a username or worker name is now validated to make sure that TrellPath can parse it
  • the spacing and order of properties in the example config TOML is now preserved when we edit the storage path and write the values back out to a new TOML

@doug-jacob
Added user input validation on names for users and workers; changed d…
00b221e 
…efault directory for user data root to be under the current working directory; changed how we parse the example config TOML file so that original spacing and order is preserved
@doug-jacob doug-jacob requested a review from oconnor0 January 20, 2025 15:44
oconnor0
oconnor0 reviewed Jan 20, 2025
View reviewed changes
Trell/CliCommands/InitCommand.cs Outdated Show resolved Hide resolved
Trell/CliCommands/InitCommand.cs Outdated Show resolved Hide resolved
@doug-jacob
Reduced amount of text given when prompting users for usernames and w…
9c9caab 
…orker names; covered an edge case where users could have bypassed input validation by passing an invalid username or worker name with the -u and -w CLI options
@doug-jacob
Removed TODO comment associated with validating user input in InitCom…
9b050ef 
…mand
oconnor0
oconnor0 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@oconnor0 oconnor0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@oconnor0 oconnor0 merged commit e71e7a8 into master Jan 20, 2025
1 check passed
@oconnor0 oconnor0 deleted the master-doug-validating-user-input-in-init branch January 20, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oconnor0 oconnor0 oconnor0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doug-jacob @oconnor0