boards/rpi_5: add rpi_5_scmi.overlay #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorc
reviewed
Sep 20, 2024
| #address-cells = <2>; | ||
| #size-cells = <1>; | ||
|
|
||
| sram0: memory@30000000 { |
There was a problem hiding this comment.
I am wondering: should you describe the SCM/SCP here as well? I.e. provide shared memory for SCMI, add scmi node, etc
There was a problem hiding this comment.
Our solution for Zephyr was not accepted. So current idea is to make Dom0 work without scmi - it should work the same way as before, without SCMI. So this patch just fixes the boot. The overlay can be extended later for SCMI.
Upstream PR for Zephyr SCMI is here zephyrproject-rtos/zephyr#78293
lorc
approved these changes
Sep 24, 2024
Add rpi_5_scmi.overlay which allows to build and run zephyr-dom0-xt application when ARM SCMI is enabled. The RAM layout is changed when ARM SCMI is enabled and Xen loads zephyr-dom0-xt app at different address 0x30000000, so rpi_5_scmi.overlay allows to cover this case. Also, in the future, it can be extended with DT SCMI nodes. The EXTRA_DTC_OVERLAY_FILE can be used to apply rpi_5_scmi.overlay. Build: west build -b rpi_5 -p always zephyr-dom0-xt -- \ -DEXTRA_DTC_OVERLAY_FILE=boards/rpi_5_scmi.overlay Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com> Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
GrygiriiS
force-pushed
the
rpi5_dom0_dev_scmi_v1
branch
from
1aa280b to
8776adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rpi_5_scmi.overlay which allows to build and run zephyr-dom0-xt application when ARM SCMI is enabled.
The RAM layout is changed when ARM SCMI is enabled and Xen loads zephyr-dom0-xt app at different address 0x30000000, so rpi_5_scmi.overlay allows to cover this case. Also, in the future, it can be extended with DT SCMI nodes.
The EXTRA_DTC_OVERLAY_FILE can be used to apply rpi_5_scmi.overlay.
Build:
west build -b rpi_5 -p always zephyr-dom0-xt --
-DEXTRA_DTC_OVERLAY_FILE=boards/rpi_5_scmi.overlay
The EXTRA_DTC_OVERLAY_FILE can be added in rpi5.yaml.