Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed Parcel 2 plugin for static files and added Rightsidebar Kodi icon #93

Merged

Conversation

developingright
Copy link
Contributor

@developingright developingright commented May 7, 2022

Hi @razzeee ,
I have closed the following PR - “Added Rightsidebar Kodi icon and hover effect on slider” because while rebasing the branch, I ran into an issue that caused a bunch of unrelated commits therefore, I thought it will be better to create a new PR and replicate the same changes in it.

I have installed the Parcel 2 plugin for the static files and have added the Rightsidebar Kodi icon with hover-effect on the slider.

Element.row []
[ image [ width (px 15), height (px 15), paddingXY 15 0 ]
{ description = ""
, src = "http://localhost:1234/logo.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url needs to be relative, when we build this for kodi (or even in dev) it's not clear, that the image will always be at that port (and host)

@developingright
Copy link
Contributor Author

Hi @razzeee,
After some research, I have found the <base> Html element, which specifies the base URL to use for all relative URLs contained within a document. This means that if you set < base href=”http//:localhost:1234”>, any relative link I would add like
<a href=”/images/logo.png”> It will automatically point to " http://localhost:1234/images/logo.png ” and we only need to define the base URL once in the index.html file which will allow us to use relative URLs anywhere in the files.

I would love to have your suggestions on this.

@razzeee
Copy link
Member

razzeee commented May 12, 2022

I think you don't even need that, you should be able to use relative paths anywhere. Base path is mostly useful when you have subpaths that are different. But feel free to play around with that.

@developingright
Copy link
Contributor Author

developingright commented May 14, 2022

Hi @razzeee,
I have made the required change.

@razzeee
Copy link
Member

razzeee commented May 15, 2022

I assume you tested and it worked?

@developingright
Copy link
Contributor Author

@razzeee,
Yes, I have tested it and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants