Skip to content

Commit

Permalink
Merge pull request #1 from wubinworks/extend-compatibility
Browse files Browse the repository at this point in the history
Extended compatibility to Magento 2.3
  • Loading branch information
wubinworks authored Jan 15, 2025
2 parents 05857dc + 32e7cfb commit 330ad1b
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
When the `SAPI` is `php-fpm`, `\Magento\Framework\Xml\Security` cannot detect entity if the XML string is not encoded in `UTF-8`.
This is a potential security issue and many developers forget to detect the XML encoding before using this class.

_Note: this class works correctly in CLI._
_Note: the above class works correctly in CLI._

##### A note about [CVE-2024-2961](https://www.cve.org/CVERecord?id=CVE-2024-2961)

_XML string with `encoding="ISO-2022-CN-EXT"` won't cause the buffer overflow. So we don't forbid this encoding._

## Features

Expand All @@ -22,6 +26,7 @@ That's it.

## Requirements

Magento 2.3
Magento 2.4

## Installation
Expand Down
13 changes: 8 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,23 @@
"xml security",
"enhancement",
"encoding",
"php-fpm"
"php-fpm",
"cosmic sting",
"cosmicsting",
"cve-2024-34102"
],
"homepage": "https://www.wubinworks.com",
"support": {
"issues": "https://github.com/wubinworks/magento2-enhanced-xml-security/issues",
"chat": "https://www.wubinworks.com/contact"
},
"require": {
"php": ">=7.3",
"laminas/laminas-xml": "^1.4",
"magento/magento2-base": "~2.4.0"
"php": ">=7.1",
"laminas/laminas-xml": "^1.2",
"magento/magento2-base": "~2.3.0 || ~2.4.0"
},
"type": "magento2-module",
"version": "1.0.0",
"version": "1.0.1",
"license": "OSL-3.0",
"authors": [
{
Expand Down

0 comments on commit 330ad1b

Please sign in to comment.