adjust beacon timeout using delay value wp-media/wp-rocket--#6741

[Khadreal]

Description

Adjust timeout, make the value dynamic

Fixes wp-media/wp-rocket#6741

Documentation

User documentation

Adjust the timeout to use the filter value from the backend.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

• Enhancement (non-breaking change which improves an existing functionality).

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

• I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Documentation

• I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
• The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
• I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

• I wrote self-explanatory code about what it does.
• I wrote comments to explain why it does it.
• I named variables and functions explicitely.
• I protected entry points against unexpected inputs.
• I did not introduce unecessary complexity.
• I listed the introduced external dependencies explicitely on the PR.
• I validated the repo-specific guidelines from CONTRIBUTING.md.

[MathieuLamiot]

@Khadreal There are conflicts to solve it seems, this branch should be updated against the trunk I guess.

Here are steps to be able to test the script with WP Rocket: https://wp-media.slack.com/archives/CUT7FLHF1/p1722526242449019?thread_ts=1722509646.276189&cid=CUT7FLHF1

[MathieuLamiot]

It seems that the expected behavior is not clear based on the discussion you are having. The expected behavior is:
if the init method runs for more than 10 seconds, then the script status result is failed.

The sequence is as follows:

1. script starts and creates a new BeaconManager.
2. On DOMContentLoaded , the script waits for rocket_beacon_data.delay
3. After the delay, init() is called.

The issue originally was that the timer was starting at point 1. Hence, the timer was running during the delay. This is something we don't want, hence the GH issue.

So, to solve this, the only thing we need is to do
this.scriptTimer = /* @__PURE__ */ new Date();
at the beginning of init() instead of when instanciating BeaconManager

Therefore, we are sure the timer only runs during init() and the delay is not impacting it, regardless of its value.

[MathieuLamiot]

Change to remove.

[MathieuLamiot]

@DahmaniAdame to confirm my latest comment. But I think the original issue jumped directly into a solution (doing delay + 10) which caused the confusion, since there is a better way to handle this.

[MathieuLamiot]

Changed base branch to develop. see https://wp-media.slack.com/archives/CUT7FLHF1/p1722593397186219?thread_ts=1722509646.276189&cid=CUT7FLHF1

[hanna-meda]

This PR looks good. Tested with steps from TC.
Thank you.