Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W4Mconcat] First version of a new tool to concatenate W4M metadata tables #269

Merged
merged 14 commits into from
Jul 10, 2024

Conversation

hanourine
Copy link
Contributor

Hello, I am currently in intership at PFEM-MetaboHub and I have developed a tool to merge Metadata tables according to W4M 3-tables format. I have tested my tool on planemo with the latest Galaxy VM and all works fine. I am looking forward to your review, in particular regarding Galaxy best practices for galaxy wrapper.
Thank you in advance.
Hanane Nourine

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

tools/w4mconcatenate/concat.xml Outdated Show resolved Hide resolved
tools/w4mconcatenate/concat.xml Outdated Show resolved Hide resolved
tools/w4mconcatenate/concat.xml Outdated Show resolved Hide resolved
tools/w4mconcatenate/concatenation_wrapper.R Outdated Show resolved Hide resolved
tools/w4mconcatenate/fonctions_auxiliaires.R Show resolved Hide resolved
tools/w4mconcatenate/fonctions_auxiliaires.R Outdated Show resolved Hide resolved
tools/w4mconcatenate/.sheld.yml.txt Outdated Show resolved Hide resolved
@hanourine
Copy link
Contributor Author

Hi everyone,
Thank you @lecorguille for the review. I tried to answer all the points along with minor cosmetics enhancement.
Is the current version ok?

@bgruening
Copy link
Contributor

@hanourine thanks a lot!

Can you maybe look at this tool: https://usegalaxy.eu/root?tool_id=toolshed.g2.bx.psu.edu/repos/iuc/table_compute/table_compute/1.2.4+galaxy0

I know its a bit complex, but I assume it can handle your use case and many more. Maybe that is useful?

changing double to simple quotes

Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
@hanourine
Copy link
Contributor Author

hanourine commented Jun 18, 2024

@hanourine thanks a lot!

Can you maybe look at this tool: https://usegalaxy.eu/root?tool_id=toolshed.g2.bx.psu.edu/repos/iuc/table_compute/table_compute/1.2.4+galaxy0

I know its a bit complex, but I assume it can handle your use case and many more. Maybe that is useful?

Thank you for your comment.
Our module handles a set of 4 files, whereas the Table Compute module would require us to use the module 3 times, increasing the risk of error. In addition, the table_compute options don't behave as expected and can't be configured as in W4Mconcat. For example:
The error is green but false in the case of input the wrong files that are not supposed to match rather than an error to the user, and on the other hand the case of use with different individuals.
In the case of common columns between the two tables, Table compute aggregates the columns instead of being able to choose between discerning one of the two columns or keeping both.
Thus, the use of Table compute requires a great deal of manipulation to obtain results where the purpose of W4Mconcat is precisely to allow a simple way and limiting false manipulation in order to obtain a consistent set of data.

@lecorguille
Copy link
Member

lintr 😋

@hanourine
Copy link
Contributor Author

Hello @lecorguille @bgruening ,

All the tests passed and I followed your recommendations. Is the pull request OK?
Thank you in advance.

Hanane Nourine

@lecorguille lecorguille merged commit eba1150 into workflow4metabolomics:master Jul 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants