전체 키워드 조회 시 학습 진도를 포함한다 #1510
Merged
전체 키워드 조회 시 학습 진도를 포함한다 #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java-saeng
approved these changes
Sep 8, 2023
BGuga
reviewed
Sep 11, 2023
| Quiz quiz = new Quiz(1L, keyword, "자바 언어의 특징은?"); | ||
| Member member = new Member(11L, "username", "nickname", Role.CREW, 101L, "https://"); | ||
| EssayAnswer essayAnswer = new EssayAnswer(quiz, "객체 지향 언어", member); | ||
| final EssayAnswer essayAnswer = createEssayAnswer(createQuizWithPK(1L)); |
There was a problem hiding this comment.
팀 프로젝트에서는 Fixture 를 만드는 Class 를 분리했었는데 이 방법을 도입하기엔 너무 많은 강을 건너온 것 같네요... 연어는 도메인 객체 생성 중복 로직을 보통 어떻게 처리하시나요??
| @Query("SELECT e FROM EssayAnswer e " + | ||
| "LEFT JOIN FETCH e.quiz q " + | ||
| "WHERE e.member.id = :memberId") | ||
| Set<EssayAnswer> findAllByMemberId(@Param("memberId") Long memberId); |
There was a problem hiding this comment.
@param 을 쓰지 않아도 변수명을 기반으로 :memberId 를 추론해주는 것으로 아닌데 명시적으로 표기하는 것을 선호하시나요??
There was a problem hiding this comment.
컴파일러에게 -parameters 옵션을 전달해주어야 내부적으로 바인딩을 합니다.
그래서 저는 컴파일 옵션의 컨디션과 상관 없이 동작하는 것을 선호합니다!
nuyh99
force-pushed
the
feat/1473-keyword-with-progress
branch
from
a685867 to
1fdf9df
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
💬리뷰 요구사항(선택)