Skip to content

Commit

Permalink
workflows/eval: make "requesting maintainer reviews" separate step
Browse files Browse the repository at this point in the history
Odd to have this in the "Tagging pull request" step, which is only about
labels otherwise.
  • Loading branch information
wolfgangwalther committed Jan 4, 2025
1 parent ffb0ace commit 2e61194
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/workflows/eval.yml
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ jobs:
- name: Build the requestReviews derivation
run: nix-build base/ci -A requestReviews

- name: Tagging pull request
- name: Labelling pull request
run: |
# Get all currently set rebuild labels
gh api \
Expand Down Expand Up @@ -283,6 +283,13 @@ jobs:
-f "labels[]=$toAdd"
done < <(comm -13 before after)
env:
GH_TOKEN: ${{ github.token }}
REPOSITORY: ${{ github.repository }}
NUMBER: ${{ github.event.number }}

- name: Requesting maintainer reviews
run: |
# maintainers.json contains GitHub IDs. Look up handles to request reviews from.
# There appears to be no API to request reviews based on GitHub IDs
jq -r 'keys[]' comparison/maintainers.json \
Expand Down

0 comments on commit 2e61194

Please sign in to comment.