lib: expose random module #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is motivated by the GUI needing to generate a salt and password for RPC user/password authentication to the managed bitcoind.
|
utACK daf6026
…-------- Original Message --------
On Feb 29, 2024, 9:23 AM, jp1ac4 wrote:
This is motivated by [#929](#929). The GUI will need to generate a salt and password for RPC user/password authentication to the managed bitcoind, and can use this module to get random bytes.
---------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#987
Commit Summary
- [daf6026](daf6026) lib: expose random module
File Changes
([1 file](https://github.com/wizardsardine/liana/pull/987/files))
- M [src/lib.rs](https://github.com/wizardsardine/liana/pull/987/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759) (2)
Patch Links:
- https://github.com/wizardsardine/liana/pull/987.patch
- https://github.com/wizardsardine/liana/pull/987.diff
—
Reply to this email directly, [view it on GitHub](#987), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F7OME4GERLIY5ZEJELYV3ZPVAVCNFSM6AAAAABD7R5R7CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE3DANZYHE3DOMI).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
darosior
added a commit
that referenced
this pull request
Mar 11, 2024
a997a7b gui: don't rely on cookie to check successful start (jp1ac4) 5e5c333 gui: use rpcauth in installer for internal bitcoind (jp1ac4) 7584b63 gui: start internal bitcoind with given config (jp1ac4) b5980fb gui: add sections check to internal bitcoind config test (jp1ac4) c3aad0f gui: add optional rpcauth to internal bitcoind config (jp1ac4) e172ecd gui: move internal bitcoind config to bitcoind module (jp1ac4) Pull request description: This is to resolve #929. The installer will generate an `rpcauth=` string for use in the managed bitcoind's bitcoin.conf file and will use the corresponding user and password in the Liana daemon config file. ~~The existence of the cookie file is still checked by `Bitcoind::start()` to determine if the process started successfully. An alternative approach could be considered in a follow-up PR (or as part of this one).~~ For #924, we might still need to use the cookie path to stop an already-running process, as we would probably no longer have the password used to generate the previous `rpcauth=` string. Once #987 is merged, I'll update the Cargo files in this PR. In the first commit, I move some code from the installer to the bitcoind module. In the end, this wasn't strictly required for the other changes I made, but I kept it as I thought it made sense anyway. ACKs for top commit: edouardparis: ACK a997a7b Tree-SHA512: ec475bb3c82db4e30c42612e93c63e9b0387311a26d5433421f275e24ac5b0923eba9bd1daff612e60a6cf0bdcc10de0812ff69972237e6785c0835b5a31450f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by #929. The GUI will need to generate a salt and password for RPC user/password authentication to the managed bitcoind, and can use this module to get random bytes.