gui: display error for rescan past pruned height #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
force-pushed
the
gui-display-rescan-error-for-past-pruned-height
branch
from
8c4a066 to
6288441
Compare
jp1ac4
reviewed
Jan 30, 2024
edouardparis
force-pushed
the
gui-display-rescan-error-for-past-pruned-height
branch
2 times, most recently
from
f66f846 to
a41d392
Compare
|
Thanks @jp1ac4 I fixed the comments and rebased |
jp1ac4
reviewed
Jan 30, 2024
edouardparis
force-pushed
the
gui-display-rescan-error-for-past-pruned-height
branch
2 times, most recently
from
952c06a to
bed1220
Compare
edouardparis
force-pushed
the
gui-display-rescan-error-for-past-pruned-height
branch
from
bed1220 to
69fd189
Compare
edouardparis
commented
Jan 31, 2024
jp1ac4
approved these changes
Jan 31, 2024
edouardparis
deleted the
gui-display-rescan-error-for-past-pruned-height
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #900
After discussion with @kloaec it is better to not return error if date is prior to genesis block date, just take genesis block timestamp