Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include entity type in aad [WPB-10108] #672

Merged
merged 18 commits into from
Sep 9, 2024

Conversation

SimonThormeyer
Copy link
Contributor

@SimonThormeyer SimonThormeyer commented Aug 29, 2024

What's new in this PR

See title


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. label Aug 29, 2024
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/aad-investigation branch 3 times, most recently from e38ab3b to eee9b0f Compare August 29, 2024 11:53
Copy link

github-actions bot commented Aug 29, 2024

🐰Bencher

ReportFri, September 6, 2024 at 16:06:45 UTC
Projectcore-crypto
Branchsimon/feat/aad-investigation
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Commit add f(group size)/cs1/mem/1002✅ (view plot)11,489,000.00
Commit add f(group size)/cs1/mem/2✅ (view plot)771,340.00
Commit add f(group size)/cs1/mem/202✅ (view plot)3,077,100.00
Commit add f(group size)/cs1/mem/402✅ (view plot)5,183,700.00
Commit add f(group size)/cs1/mem/602✅ (view plot)8,099,900.00
Commit add f(group size)/cs1/mem/802✅ (view plot)9,976,500.00
Commit add f(number clients)/cs1/mem/1002✅ (view plot)989,770,000.00
Commit add f(number clients)/cs1/mem/2✅ (view plot)803,030.00
Commit add f(number clients)/cs1/mem/202✅ (view plot)78,427,000.00
Commit add f(number clients)/cs1/mem/402✅ (view plot)214,100,000.00
Commit add f(number clients)/cs1/mem/602✅ (view plot)425,990,000.00
Commit add f(number clients)/cs1/mem/802✅ (view plot)676,120,000.00
Commit pending proposals f(group size)/cs1/mem/1002✅ (view plot)111,420,000.00
Commit pending proposals f(group size)/cs1/mem/2✅ (view plot)22,424,000.00
Commit pending proposals f(group size)/cs1/mem/202✅ (view plot)40,287,000.00
Commit pending proposals f(group size)/cs1/mem/402✅ (view plot)55,183,000.00
Commit pending proposals f(group size)/cs1/mem/602✅ (view plot)74,398,000.00
Commit pending proposals f(group size)/cs1/mem/802✅ (view plot)89,249,000.00
Commit pending proposals f(pending size)/cs1/mem/1✅ (view plot)11,392,000.00
Commit pending proposals f(pending size)/cs1/mem/101✅ (view plot)110,740,000.00
Commit pending proposals f(pending size)/cs1/mem/21✅ (view plot)28,816,000.00
Commit pending proposals f(pending size)/cs1/mem/41✅ (view plot)49,847,000.00
Commit pending proposals f(pending size)/cs1/mem/61✅ (view plot)69,802,000.00
Commit pending proposals f(pending size)/cs1/mem/81✅ (view plot)89,919,000.00
Commit remove f(group size)/cs1/mem/1002✅ (view plot)19,951,000.00
Commit remove f(group size)/cs1/mem/2✅ (view plot)555,850.00
Commit remove f(group size)/cs1/mem/202✅ (view plot)2,275,200.00
Commit remove f(group size)/cs1/mem/402✅ (view plot)5,070,000.00
Commit remove f(group size)/cs1/mem/602✅ (view plot)10,073,000.00
Commit remove f(group size)/cs1/mem/802✅ (view plot)14,398,000.00
Commit remove f(number clients)/cs1/mem/1002✅ (view plot)22,452,000.00
Commit remove f(number clients)/cs1/mem/2✅ (view plot)128,670,000.00
Commit remove f(number clients)/cs1/mem/202✅ (view plot)107,490,000.00
Commit remove f(number clients)/cs1/mem/402✅ (view plot)85,792,000.00
Commit remove f(number clients)/cs1/mem/602✅ (view plot)64,677,000.00
Commit remove f(number clients)/cs1/mem/802✅ (view plot)44,105,000.00
Commit update f(group size)/cs1/mem/1002✅ (view plot)130,220,000.00
Commit update f(group size)/cs1/mem/2✅ (view plot)751,900.00
Commit update f(group size)/cs1/mem/202✅ (view plot)27,030,000.00
Commit update f(group size)/cs1/mem/402✅ (view plot)52,615,000.00
Commit update f(group size)/cs1/mem/602✅ (view plot)79,419,000.00
Commit update f(group size)/cs1/mem/802✅ (view plot)104,180,000.00
Count KeyPackage/cs1/mem/1002✅ (view plot)3,682,700.00
Count KeyPackage/cs1/mem/2✅ (view plot)433,490.00
Count KeyPackage/cs1/mem/202✅ (view plot)828,970.00
Count KeyPackage/cs1/mem/402✅ (view plot)1,534,900.00
Count KeyPackage/cs1/mem/602✅ (view plot)2,241,700.00
Count KeyPackage/cs1/mem/802✅ (view plot)2,992,200.00
Create group/cs1/mem✅ (view plot)327,330.00
Decrypt f(msg size)/cs1/mem/10✅ (view plot)274,890.00
Decrypt f(msg size)/cs1/mem/10010✅ (view plot)304,300.00
Decrypt f(msg size)/cs1/mem/2010✅ (view plot)277,680.00
Decrypt f(msg size)/cs1/mem/4010✅ (view plot)266,730.00
Decrypt f(msg size)/cs1/mem/6010✅ (view plot)289,720.00
Decrypt f(msg size)/cs1/mem/8010✅ (view plot)288,530.00
Encrypt f(group size)/cs1/mem/1002✅ (view plot)1,000,000.00
Encrypt f(group size)/cs1/mem/2✅ (view plot)275,840.00
Encrypt f(group size)/cs1/mem/202✅ (view plot)448,920.00
Encrypt f(group size)/cs1/mem/402✅ (view plot)619,160.00
Encrypt f(group size)/cs1/mem/602✅ (view plot)742,410.00
Encrypt f(group size)/cs1/mem/802✅ (view plot)876,220.00
Encrypt f(msg size)/cs1/mem/10✅ (view plot)979,690.00
Encrypt f(msg size)/cs1/mem/10010✅ (view plot)1,025,100.00
Encrypt f(msg size)/cs1/mem/2010✅ (view plot)1,003,000.00
Encrypt f(msg size)/cs1/mem/4010✅ (view plot)1,045,000.00
Encrypt f(msg size)/cs1/mem/6010✅ (view plot)1,053,700.00
Encrypt f(msg size)/cs1/mem/8010✅ (view plot)1,088,200.00
Generate KeyPackage f(group size)/cs1/mem/1002✅ (view plot)193,690,000.00
Generate KeyPackage f(group size)/cs1/mem/2✅ (view plot)553,290.00
Generate KeyPackage f(group size)/cs1/mem/202✅ (view plot)22,246,000.00
Generate KeyPackage f(group size)/cs1/mem/402✅ (view plot)64,517,000.00
Generate KeyPackage f(group size)/cs1/mem/602✅ (view plot)106,870,000.00
Generate KeyPackage f(group size)/cs1/mem/802✅ (view plot)149,660,000.00
Join from external commit f(group size)/cs1/mem/1002✅ (view plot)231,760,000.00
Join from external commit f(group size)/cs1/mem/2✅ (view plot)1,491,500.00
Join from external commit f(group size)/cs1/mem/202✅ (view plot)48,145,000.00
Join from external commit f(group size)/cs1/mem/402✅ (view plot)94,527,000.00
Join from external commit f(group size)/cs1/mem/602✅ (view plot)141,560,000.00
Join from external commit f(group size)/cs1/mem/802✅ (view plot)186,130,000.00
Join from welcome f(group size)/cs1/mem/1002✅ (view plot)109,280,000.00
Join from welcome f(group size)/cs1/mem/2✅ (view plot)943,290.00
Join from welcome f(group size)/cs1/mem/202✅ (view plot)22,829,000.00
Join from welcome f(group size)/cs1/mem/402✅ (view plot)44,588,000.00
Join from welcome f(group size)/cs1/mem/602✅ (view plot)66,556,000.00
Join from welcome f(group size)/cs1/mem/802✅ (view plot)87,896,000.00
Mls vs Proteus: add/MLS/mem/1✅ (view plot)735,100.00
Mls vs Proteus: add/MLS/mem/101✅ (view plot)1,892,500.00
Mls vs Proteus: add/MLS/mem/21✅ (view plot)958,130.00
Mls vs Proteus: add/MLS/mem/41✅ (view plot)1,234,200.00
Mls vs Proteus: add/MLS/mem/61✅ (view plot)1,343,400.00
Mls vs Proteus: add/MLS/mem/81✅ (view plot)1,727,000.00
Mls vs Proteus: add/Proteus/mem/1✅ (view plot)452,390.00
Mls vs Proteus: add/Proteus/mem/101✅ (view plot)34,764,000.00
Mls vs Proteus: add/Proteus/mem/21✅ (view plot)7,367,000.00
Mls vs Proteus: add/Proteus/mem/41✅ (view plot)14,147,000.00
Mls vs Proteus: add/Proteus/mem/61✅ (view plot)21,016,000.00
Mls vs Proteus: add/Proteus/mem/81✅ (view plot)27,942,000.00
Mls vs Proteus: encrypt/MLS/mem/1✅ (view plot)269,180.00
Mls vs Proteus: encrypt/MLS/mem/101✅ (view plot)346,460.00
Mls vs Proteus: encrypt/MLS/mem/21✅ (view plot)276,640.00
Mls vs Proteus: encrypt/MLS/mem/41✅ (view plot)308,450.00
Mls vs Proteus: encrypt/MLS/mem/61✅ (view plot)314,020.00
Mls vs Proteus: encrypt/MLS/mem/81✅ (view plot)322,780.00
Mls vs Proteus: encrypt/Proteus/mem/1✅ (view plot)181,040.00
Mls vs Proteus: encrypt/Proteus/mem/101✅ (view plot)8,273,200.00
Mls vs Proteus: encrypt/Proteus/mem/21✅ (view plot)1,828,000.00
Mls vs Proteus: encrypt/Proteus/mem/41✅ (view plot)3,427,700.00
Mls vs Proteus: encrypt/Proteus/mem/61✅ (view plot)5,075,600.00
Mls vs Proteus: encrypt/Proteus/mem/81✅ (view plot)6,616,300.00
Mls vs Proteus: remove/MLS/mem/1✅ (view plot)13,799,000.00
Mls vs Proteus: remove/MLS/mem/101✅ (view plot)1,725,100.00
Mls vs Proteus: remove/MLS/mem/21✅ (view plot)11,324,000.00
Mls vs Proteus: remove/MLS/mem/41✅ (view plot)8,889,700.00
Mls vs Proteus: remove/MLS/mem/61✅ (view plot)6,539,700.00
Mls vs Proteus: remove/MLS/mem/81✅ (view plot)4,125,700.00
Mls vs Proteus: remove/Proteus/mem/1✅ (view plot)98,529.00
Mls vs Proteus: remove/Proteus/mem/101✅ (view plot)592,820.00
Mls vs Proteus: remove/Proteus/mem/21✅ (view plot)190,090.00
Mls vs Proteus: remove/Proteus/mem/41✅ (view plot)298,490.00
Mls vs Proteus: remove/Proteus/mem/61✅ (view plot)408,780.00
Mls vs Proteus: remove/Proteus/mem/81✅ (view plot)507,040.00
Mls vs Proteus: update/MLS/mem/1✅ (view plot)700,450.00
Mls vs Proteus: update/MLS/mem/101✅ (view plot)13,740,000.00
Mls vs Proteus: update/MLS/mem/21✅ (view plot)3,425,100.00
Mls vs Proteus: update/MLS/mem/41✅ (view plot)6,084,700.00
Mls vs Proteus: update/MLS/mem/61✅ (view plot)8,582,900.00
Mls vs Proteus: update/MLS/mem/81✅ (view plot)11,291,000.00
Mls vs Proteus: update/Proteus/mem/1✅ (view plot)445,480.00
Mls vs Proteus: update/Proteus/mem/101✅ (view plot)35,382,000.00
Mls vs Proteus: update/Proteus/mem/21✅ (view plot)7,482,400.00
Mls vs Proteus: update/Proteus/mem/41✅ (view plot)14,502,000.00
Mls vs Proteus: update/Proteus/mem/61✅ (view plot)21,443,000.00
Mls vs Proteus: update/Proteus/mem/81✅ (view plot)28,324,000.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@SimonThormeyer SimonThormeyer force-pushed the simon/feat/aad-investigation branch 7 times, most recently from 9b830d1 to 27144d0 Compare August 30, 2024 08:15
@istankovic
Copy link
Member

Commit 389ba18ffd61c12fa483df7c801d4f076c73b453 has message

refactor: MlsKeyPackage::find_all() in fetch_keypackages

It feels like a use is missing in front of MlsKeyPackage.

@SimonThormeyer SimonThormeyer force-pushed the simon/feat/aad-investigation branch from 27144d0 to 7655339 Compare August 30, 2024 09:18
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/aad-investigation branch from 44d6737 to 1b74775 Compare September 6, 2024 09:56
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/aad-investigation branch 3 times, most recently from 3a34576 to f6f7958 Compare September 6, 2024 11:23
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/aad-investigation branch 9 times, most recently from 90d79cf to 4b3f6a6 Compare September 6, 2024 15:29
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/aad-investigation branch 3 times, most recently from b7fc35a to e3aaae9 Compare September 6, 2024 15:54
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/aad-investigation branch from e3aaae9 to d605d30 Compare September 6, 2024 16:06
Copy link
Member

@istankovic istankovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive work, good job!

@istankovic istankovic merged commit 48ea746 into main Sep 9, 2024
24 checks passed
@SimonThormeyer SimonThormeyer deleted the simon/feat/aad-investigation branch November 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants