Added building and access via webapp to the Storybook design inventory (Part 2) #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y (Part 2) Now do the redirect in App.jsx. New https requests will be intercepted before they get to the React Router, and the DOM window.location.hrf and if pointed at /storybook will be reset to the desired /storybook/index.html Works fine locally (as did the prior approach), we will see how it does on the production servers. Implements https://wevoteusa.atlassian.net/browse/WV-206
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now do the redirect in App.jsx.
New https requests will be intercepted before they get to the React Router, and the DOM window.location.href and if pointed at /storybook will be reset to the desired /storybook/index.html
Works fine locally (as did the prior approach), we will see how it does on the production servers.
Implements https://wevoteusa.atlassian.net/browse/WV-206