Update button activation behaviours #51000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does a few things to align with the latest spec, based on the changes in whatwg/html#11053. - Reset buttons should _only_ reset the form, not trigger additional popover or command behaviours. - Buttons should reflect "button" when command/commandfor attributes are present, with or without a form-owner. - Buttons that reflect "button" with command/commandfor attributes that have a form-owner should be no-op; this is a restriction for back-compat that will eventually be lifted. whatwg/html#10832 tracks the state of this, and consequently I've added a UseCounter to help figure out when it is safe to make this change. Bug: 399124617 Change-Id: I684371bb7fc8e0888bcf0713caff212f4806a7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304979 Commit-Queue: Keith Cirkel <chromium@keithcirkel.co.uk> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425642}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does a few things to align with the latest spec, based on the changes in whatwg/html#11053.
type=submitandcommand/commandforbeing no-op whatwg/html#10832 tracks the state of this, and consequently I've added a UseCounter to help figure out when it is safe to make this change.Bug: 399124617
Change-Id: I684371bb7fc8e0888bcf0713caff212f4806a7c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304979
Commit-Queue: Keith Cirkel chromium@keithcirkel.co.uk
Reviewed-by: Mason Freed masonf@chromium.org
Cr-Commit-Position: refs/heads/main@{#1425642}