enhance: post form builder settings #1513
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -165,7 +165,7 @@ protected function set_basename_and_slug() { | |
|
|
||
| require_once ABSPATH . 'wp-admin/includes/plugin.php'; | ||
|
|
||
| $plugin_data = get_plugin_data( $this->file, true, false ); | ||
|
|
||
| $this->project_version = $plugin_data['Version']; | ||
| $this->type = 'plugin'; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,179 @@ | ||||||
| Vue.component('builder-stage-v4-1', { | ||||||
| template: '#tmpl-wpuf-builder-stage-v4-1', | ||||||
|
|
||||||
| mixins: wpuf_form_builder_mixins(wpuf_mixins.builder_stage).concat(wpuf_mixins.add_form_field), | ||||||
|
|
||||||
| computed: { | ||||||
| form_fields: function () { | ||||||
| return this.$store.state.form_fields; | ||||||
| }, | ||||||
|
|
||||||
| field_settings: function () { | ||||||
| return this.$store.state.field_settings; | ||||||
| }, | ||||||
|
|
||||||
| hidden_fields: function () { | ||||||
| return this.$store.state.form_fields.filter(function (item) { | ||||||
| return 'custom_hidden_field' === item.template; | ||||||
| }); | ||||||
| }, | ||||||
|
|
||||||
| editing_form_id: function () { | ||||||
| return this.$store.state.editing_field_id; | ||||||
| }, | ||||||
| }, | ||||||
|
|
||||||
| mounted: function () { | ||||||
| var self = this, | ||||||
| in_column_field = false; | ||||||
|
|
||||||
| // bind jquery ui sortable | ||||||
| $('#form-preview-stage, #form-preview-stage .wpuf-form.sortable-list').sortable({ | ||||||
| placeholder: 'form-preview-stage-dropzone', | ||||||
| items: '.field-items', | ||||||
| handle: '.field-buttons .move', | ||||||
| scroll: true, | ||||||
| over: function() { | ||||||
| in_column_field = false; | ||||||
|
|
||||||
| // if the field drop in column field, then stop field rendering in the builder stage | ||||||
| $(".wpuf-column-inner-fields" ).on( "drop", function(event) { | ||||||
| var targetColumn = event.currentTarget.classList, | ||||||
| isColumnExist = $.inArray(".wpuf-column-inner-fields", targetColumn); | ||||||
|
|
||||||
| if ( isColumnExist ) { | ||||||
| in_column_field = true; | ||||||
| } | ||||||
| } ); | ||||||
| }, | ||||||
| update: function (e, ui) { | ||||||
| var item = ui.item[0], | ||||||
| data = item.dataset, | ||||||
| source = data.source, | ||||||
| toIndex = parseInt($(ui.item).index()), | ||||||
| payload = { | ||||||
| toIndex: toIndex | ||||||
| }; | ||||||
|
|
||||||
| if ('panel' === source) { | ||||||
| // add new form element | ||||||
| self.$store.state.index_to_insert = parseInt(toIndex); | ||||||
|
|
||||||
| if ( ! in_column_field ) { | ||||||
| var field_template = ui.item[0].dataset.formField; | ||||||
| self.add_form_field(field_template); | ||||||
| } | ||||||
|
|
||||||
| // remove button from stage | ||||||
| $(this).find('.wpuf-field-button').remove(); | ||||||
|
|
||||||
| } else if ('stage' === source) { | ||||||
| payload.fromIndex = parseInt(data.index); | ||||||
|
|
||||||
| self.$store.commit('swap_form_field_elements', payload); | ||||||
| } | ||||||
|
|
||||||
| } | ||||||
| }); | ||||||
| }, | ||||||
|
|
||||||
| methods: { | ||||||
| open_field_settings: function(field_id) { | ||||||
| this.$store.commit('open_field_settings', field_id); | ||||||
| }, | ||||||
|
|
||||||
| clone_field: function(field_id, index) { | ||||||
| var payload = { | ||||||
| field_id: field_id, | ||||||
| index: index, | ||||||
| new_id: this.get_random_id() | ||||||
| }; | ||||||
|
|
||||||
| // single instance checking | ||||||
| var field = _.find(this.$store.state.form_fields, function (item) { | ||||||
| return parseInt(item.id) === parseInt(payload.field_id); | ||||||
| }); | ||||||
|
|
||||||
| // check if these are already inserted | ||||||
| if ( this.isSingleInstance( field.template ) && this.containsField( field.template ) ) { | ||||||
| Swal.fire({ | ||||||
| title: "Oops...", | ||||||
| text: "You already have this field in the form" | ||||||
| }); | ||||||
| return; | ||||||
| } | ||||||
|
|
||||||
| this.$store.commit('clone_form_field_element', payload); | ||||||
| }, | ||||||
|
|
||||||
| delete_field: function(index) { | ||||||
| var self = this; | ||||||
|
|
||||||
| (Swal.fire({ | ||||||
| text: self.i18n.delete_field_warn_msg, | ||||||
| icon: 'warning', | ||||||
| showCancelButton: true, | ||||||
| confirmButtonColor: '#d54e21', | ||||||
| confirmButtonText: self.i18n.yes_delete_it, | ||||||
| cancelButtonText: self.i18n.no_cancel_it, | ||||||
| customClass: { | ||||||
| confirmButton: 'btn btn-success', | ||||||
| cancelButton: 'btn btn-danger', | ||||||
| } | ||||||
| })).then((result) => { | ||||||
| if (result.isConfirmed) { | ||||||
| self.$store.commit('delete_form_field_element', index); | ||||||
| } | ||||||
| }); | ||||||
| }, | ||||||
|
|
||||||
| delete_hidden_field: function (field_id) { | ||||||
| var i = 0; | ||||||
|
|
||||||
| for (i = 0; i < this.form_fields.length; i++) { | ||||||
| if (parseInt(field_id) === parseInt(this.form_fields[i].id)) { | ||||||
| this.delete_field(i); | ||||||
| } | ||||||
| } | ||||||
| }, | ||||||
|
|
||||||
| is_pro_feature: function (template) { | ||||||
| return ( this.field_settings[template] && this.field_settings[template].pro_feature ) ? true : false; | ||||||
| }, | ||||||
|
|
||||||
| is_template_available: function (field) { | ||||||
| var template = field.template; | ||||||
|
|
||||||
| if (this.field_settings[template]) { | ||||||
| if (this.is_pro_preview(template)) { | ||||||
|
There was a problem hiding this comment. Fix incorrect method name. The method - if (this.is_pro_preview(template)) {
+ if (this.is_pro_feature(template)) {📝 Committable suggestion
Suggested change
|
||||||
| return false; | ||||||
| } | ||||||
|
|
||||||
| return true; | ||||||
| } | ||||||
|
|
||||||
| // for example see 'mixin_builder_stage' mixin's 'is_taxonomy_template_available' method | ||||||
| if (_.isFunction(this['is_' + template + '_template_available'])) { | ||||||
| return this['is_' + template + '_template_available'].call(this, field); | ||||||
| } | ||||||
|
|
||||||
| return false; | ||||||
| }, | ||||||
|
|
||||||
| is_full_width: function (template) { | ||||||
| if (this.field_settings[template] && this.field_settings[template].is_full_width) { | ||||||
| return true; | ||||||
| } | ||||||
|
|
||||||
| return false; | ||||||
| }, | ||||||
|
|
||||||
| is_invisible: function (field) { | ||||||
| return ( field.recaptcha_type && 'invisible_recaptcha' === field.recaptcha_type ) ? true : false; | ||||||
| }, | ||||||
|
|
||||||
| get_field_name: function (template) { | ||||||
| return this.field_settings[template].title; | ||||||
| } | ||||||
| } | ||||||
| }); | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add validation for Tailwind CLI input and output paths.
The current implementation doesn't validate the input and output paths before executing the Tailwind CLI command. This could lead to errors if the paths contain spaces or special characters.
tailwind: { command: function ( input, output ) { - return `npx tailwindcss -i ${input} -o ${output}`; + // Validate and sanitize input and output paths + const sanitizedInput = input.replace(/[^a-zA-Z0-9/\-_.]/g, ''); + const sanitizedOutput = output.replace(/[^a-zA-Z0-9/\-_.]/g, ''); + + if (sanitizedInput !== input || sanitizedOutput !== output) { + grunt.log.warn('Input or output paths contain invalid characters and were sanitized.'); + } + + return `npx tailwindcss -i "${sanitizedInput}" -o "${sanitizedOutput}"`; } }📝 Committable suggestion