Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Auth0 device code authorization and refresh token flow #31

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

sn3ek
Copy link
Contributor

@sn3ek sn3ek commented Jan 19, 2025

This PR provides the auth0 device code and refresh token flow.

In order to use it you have to provide client_id, domain and audience of your Wandelbots Developer account.

@sn3ek sn3ek force-pushed the feature/add-device-code-authorization branch 8 times, most recently from 88d68ef to ec56c8b Compare January 19, 2025 10:38
@sn3ek sn3ek force-pushed the feature/add-device-code-authorization branch from ec56c8b to 65be94e Compare January 19, 2025 10:41
Copy link
Member

@stefanwagnerdev stefanwagnerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why didn't you used the sdk from auth0
https://github.com/auth0/auth0-python ?

@stefanwagnerdev
Copy link
Member

I would be nice if we add some convenient login functions around that. This could internally store the refresh token and handle any authentication issues on its on (by intercepting any calls to the Api)

nova/auth/authorization.py Outdated Show resolved Hide resolved
nova/auth/authorization.py Outdated Show resolved Hide resolved
@biering
Copy link
Collaborator

biering commented Jan 20, 2025

please add example or some docs in README.md

@sn3ek
Copy link
Contributor Author

sn3ek commented Jan 20, 2025

why didn't you used the sdk from auth0 https://github.com/auth0/auth0-python ?

Because the Auth0 SDK does not support device_code auth. 🤷

@biering
Copy link
Collaborator

biering commented Jan 20, 2025

lgtm

nova/auth/authorization.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@biering biering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sn3ek and others added 2 commits January 20, 2025 13:01
Co-authored-by: Christoph Biering <1353438+biering@users.noreply.github.com>
@sn3ek sn3ek merged commit 06f42ab into main Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants