Security 관련 수정 및 리팩토링 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* migration: add council_file table * feat: add council file entity, repository * feat: add council file handling to attachment * feat: define key for rule, meetingminute * feat: define dto for base, rule, meeting minute * feat: add counfil file service * feat: define response bodies for council file * feat: add api for council file * review: remove nested 'it' * review: remove verbose use of maps
* CouncilIntro RU api * apply upsert and findFirst intro * ktlint
* migration: add council_file table * feat: add council file entity, repository * feat: add council file handling to attachment * feat: define key for rule, meetingminute * feat: define dto for base, rule, meeting minute * feat: add counfil file service * feat: define response bodies for council file * feat: add api for council file * review: remove nested 'it' * review: remove verbose use of maps
…/csereal-server into fix/method-security
huGgW
reviewed
Feb 21, 2025
huGgW
approved these changes
Feb 23, 2025
로그인할때 받는건 같은데 우리 db에 저장하지 않고 그냥 Security에서 관리하는 authentication 객체에 저장해서 쓰는것! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
보안 관련 수정사항
한줄 요약
학생회 페이지 권한 추가하면서 기존 코드 개선
상세 설명
[c49b6e6]: admin api 제한은 전역 설정으로 이동
[e1a585e]: 현재 로그인 유저 받아오는 로직을 통일하기 위해 기존 CustomPrincipal 대신 CustomOidcUser 생성
[2ea5be3]: 유저 테이블에서 role 삭제
[6645300]: 커스텀 어노테이션 Spring Security에서 제공하는 PreAuthorize로 대체
[8e7883c]: 서비스 레이어에서 유저 혹은 권한 받아오는 부분 유틸 함수로 리팩토링
[79de8e7]: is-staff api를 현재 유저 권한 받는 api로 변경
[fbbe372]: 파라미터를 통해 mock-login시 권한 선택 가능하게 변경 및 mock-logout 추가
[7b9bb07]: 테스트를 위해 getLoginUser는 userService로 이동
TODO
dev test